This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
[WIP] fix up bridge module bugs #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3ngyang
requested review from
danintel,
EugeneYYY,
manju956,
manojgop,
Ram-srini and
TomBarnes
as code owners
m3ngyang
force-pushed
the
fix-bridge
branch
from
4eb3ec7
to
3887e29
Compare
|
The build failed because you are missing a "DCO line". Signed-off-by: m3ngyang [email protected] For details, see This is a legal requirement of The Linux Foundation and the Hyperledger consortium. Rebase your commit and force push to update. |
danintel
suggested changes
Sep 13, 2019
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| [KvStorage] | |||
| StoragePath = "config/Kv_Shared_tmp" | |||
| StorageSize = "1 TB" | |||
| StorageSize = "1 GB" | |||
There was a problem hiding this comment.
1 GByte is very small. The space for the file is not allocated until used, so 1 TByte allows room to grow.
There was a problem hiding this comment.
1 GB is only for local test, which won't be included in the final commit.
|
@m3ngyang Can you please update your commit with sign off message. |
Signed-off-by: mengyang02 <[email protected]>
m3ngyang
force-pushed
the
fix-bridge
branch
from
3887e29
to
23fda2a
Compare
|
@Ram-srini singed off. but this pr is not finished. |
m3ngyang
requested review from
dcmiddle,
karthikamurthy,
pankajgoyal2 and
SriharshaSubbakrishna
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bridge module doesn't work currently. This pr aims to fix the problem. #51