This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix dependencies to build on ARM #2432
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLEckhardt
requested review from
agunde406,
cianx,
dcmiddle,
dplumb94,
jsmitchell,
ltseeley,
peterschwarz,
rberg2,
rbuysse and
vaporos
as code owners
Updates many dependencies to enable sawtooth validator to build and run on ARM. Fixes a memory leak that occurs when using the currently published image on ARM. Some packages that were pulled in via apt install (ex. python3-pyformance, python3-grpcio, etc.) aren't published for ARM, so we need to install them via pip. To install them via pip, we need to lock versions for some of the packages to continue to use python3.6 and be compatible with Grid. Some packages need to be up-to-date and not version-locked. Installing packages via pip is done in steps, as some packages need to be finished installing before calling `pip install ...` for others. This also removes the dependency declarations in `setup.py` and `stdeb.cfg` files, as these mostly refer to packages without compatible ARM versions published. They are also silent failures in the build process. I suspect that using an updated version of lmdb resolved the memory leak. Note: This only updates the bionic docker-compose files, since we are only supporting bionic. Signed-off-by: Chris Eckhardt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates many dependencies to enable sawtooth validator to build and
run on ARM. Fixes a memory leak that occurs when using the currently
published image on ARM.
Some packages that were pulled in via apt install (ex.
python3-pyformance, python3-grpcio, etc.) aren't published for ARM, so
we need to install them via pip. To install them via pip, we need to
lock versions for some of the packages to continue to use python3.6 and
be compatible with Grid. Some packages need to be up-to-date and not
version-locked. Installing packages via pip is done in steps, as some
packages need to be finished installing before calling
pip install ...for others.
This also removes the dependency declarations in
setup.pyandstdeb.cfgfiles, as these mostly refer to packages withoutcompatible ARM versions published. They are also silent failures in the
build process.
I suspect that using an updated version of lmdb resolved the memory
leak.
Note: This only updates the bionic docker-compose files, since we are
only supporting bionic.
Signed-off-by: Chris Eckhardt [email protected]