This repository was archived by the owner on Apr 27, 2023. It is now read-only.
Document challenge generation API #15
Open
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovesh
requested review from
brentzundel,
danintel,
dcmiddle,
dhuseby,
dubovitskaya,
hartm,
mac-arrap,
manudrijvers,
mikelodder7 and
vaporos
as code owners
mikelodder7
reviewed
Nov 21, 2019
text/ps-signatures/README.md
Outdated
| } | ||
| ``` | ||
| - To generate the challenge, the prover will need to get bytes for the pre-challenge phase. This can be done by using `PoKOfSignature::to_bytes` method. | ||
| - For the verifier to generate the challenge, it will get bytes for the pre-challenge phase by calling `PoKOfSignatureProof::get_bytes_for_challenge`. `revealed_msg_indices` corresponds to the messages revealed to the verifier since they are not included in the proof of knowledge protocol. |
Contributor
There was a problem hiding this comment.
The Verifier generates the challenge by retrieving all relavant bytes for the pre-challenge phase by calling ...
mikelodder7
suggested changes
Nov 21, 2019
Contributor
mikelodder7
left a comment
mikelodder7
left a comment
There was a problem hiding this comment.
Just change the text so something similar to this suggestion as it reads easier and is more clearly stated.
Signed-off-by: lovesh <[email protected]>
brentzundel
approved these changes
Dec 2, 2019
dcmiddle
approved these changes
Jul 22, 2020
Contributor
|
Should we have merged this a while back? It looks like the feedback was addressed and the PS scheme is in the code (currently under zmix). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lovesh [email protected]