[quorum] integrate aws secrets manager#2623
Merged
sownak merged 1 commit intohyperledger-bevel:developfrom Sep 25, 2024
Merged
Conversation
saurabhkumarkardam
requested review from
adityajoshi12,
sownak and
suvajit-sarkar
as code owners
sownak
reviewed
Sep 18, 2024
sownak
requested changes
Sep 18, 2024
Contributor
sownak
left a comment
sownak
left a comment
There was a problem hiding this comment.
condition needs to be checked.
Contributor
|
The keys will conflict if same platforms are deployed using the same secret manager region. See if the keys can be made unique using the namespace |
saurabhkumarkardam
force-pushed
the
quorum-2200
branch
from
9e3e8f1 to
b315d2b
Compare
saurabhkumarkardam
force-pushed
the
quorum-2200
branch
from
b315d2b to
909e108
Compare
sownak
requested changes
Sep 20, 2024
saurabhkumarkardam
force-pushed
the
quorum-2200
branch
from
909e108 to
192b6d3
Compare
This PR will allow the use of the AWS service called Secrets Manager to store sensitive information, similar to how we use HashiCorp Vault for the same purpose. - A guide named "integrate-aws-secrets-manager-with-eks.md" has been introduced to help users securely connect their EKS cluster with Secrets Manager using OIDC. - The Quorum master README has been updated to guide users on how to deploy a network with AWS Secrets Manager. - A Python script has been added that contains the CRUD operation code for AWS Secrets Manager, injecting the script into the container via ConfigMap. - The Quorum Genesis and Node charts code have been updated to support Secrets Manager. fixes hyperledger-bevel#2200 Signed-off-by: saurabhkumarkardam <saurabh.kumar.kardam@accenture.com>
saurabhkumarkardam
force-pushed
the
quorum-2200
branch
from
192b6d3 to
ed7bbde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(quorum): integrate aws secrets manager
fixes #2200