Adding more logs to ws client for connect - #193
Merged
EnriqueL8 merged 3 commits intoOct 16, 2025
Conversation
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
EnriqueL8
reviewed
Oct 9, 2025
EnriqueL8
left a comment
EnriqueL8
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Chengxuan this is going to be super helpful to diagnose
| func (w *wsClient) connect(initial bool) error { | ||
| l := log.L(w.ctx) | ||
| l.Debugf("WS %s connecting, isInitial: %t", w.url, initial) | ||
| return w.connRetry.DoCustomLog(w.ctx, func(attempt int) (retry bool, err error) { |
Contributor
There was a problem hiding this comment.
aah DoCustomLog doesn't log attempts, now it makes sense to add the below attempt logs!
Chengxuan
commented
Oct 9, 2025
Chengxuan
commented
Oct 9, 2025
Chengxuan
commented
Oct 9, 2025
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Contributor
Author
|
Thanks for the review. @EnriqueL8 I've addressed the review comments. I've kept the |
EnriqueL8
approved these changes
Oct 16, 2025
EnriqueL8
left a comment
EnriqueL8
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Chengxuan - looks good now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more logs to
connectand reconnect logic for debugging purposes. The code paths do not execute once the websocket client is in normal operation mode(heavy traffic). Therefore, I think it's helpful to make them verbose.