do not mutate scoped filter - #198
Merged
peterbroadhurst merged 2 commits intoNov 3, 2025
Merged
Conversation
Signed-off-by: John Hosie <john.hosie@kaleido.io>
hosie
commented
Nov 3, 2025
| //Get many still returns all scope1 rows | ||
| cs, _, err = scopedCollection.GetMany(ctx, CRUDableQueryFactory.NewFilter(ctx).And()) | ||
| assert.NoError(t, err) | ||
| require.Len(t, cs, 2) |
Contributor
Author
There was a problem hiding this comment.
Without the fix in this PR, this call to GetMany would return only one record
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idFilterwas modifying the scoped filter on a collection with anidfilter condition and any attempts read from that collection afterwards, would always be scoped to a single record.This PR changes that so we now only read from the scoped filter and do not modify it.