Skip to content

fixing enum compare to be case insensitive for FFEnumParseString #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbroadhurst merged 2 commits into from
Jun 10, 2026
+30 −4
Merged

fixing enum compare to be case insensitive for FFEnumParseString #217

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dfedc8
fixing enum compare to be case insensitive
Chengxuan Jun 5, 2026
d28788b
address review comments
Chengxuan Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/fftypes/enum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,12 @@ func FFEnumParseString(ctx context.Context, t, val string) (FFEnum, error) {
return "", i18n.NewError(ctx, i18n.MsgInvalidEnum, t)
}
for _, possible := range e {
if possible == strings.ToLower(val) {
return FFEnum(strings.ToLower(val)), nil
possibleStr, ok := possible.(string)

@peterbroadhurst peterbroadhurst Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just (string)possible simple type casting should be possible here for a known type, rather than interface

@Chengxuan Chengxuan Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. conversion to interface{} is only needed for FFEnumValues as that function is used for openapi.

Updated the code to make that clear.

if !ok {
continue
}
if strings.EqualFold(possibleStr, val) {
return FFEnum(strings.ToLower(possibleStr)), nil
}
}
return "", i18n.NewError(ctx, i18n.MsgInvalidEnumValue, val, t, e)
Expand Down
6 changes: 6 additions & 0 deletions pkg/fftypes/enum_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,10 @@ func TestFFEnumParseString(t *testing.T) {
v, err = FFEnumParseString(ctx, "ut", "foobar")
assert.Regexp(t, "FF00172", err)
assert.Empty(t, v)

mixed := FFEnumValue("ut_mixed", "Test_Enum_Mixed")
v, err = FFEnumParseString(ctx, "ut_mixed", "test_enum_mixed")
assert.NoError(t, err)
assert.Equal(t, FFEnum("test_enum_mixed"), v)
assert.Equal(t, mixed.Lower(), v)
}
Loading