Surface block timestamp in confirmationUpdateResult - #226
Merged
Chengxuan merged 2 commits intoSep 2, 2026
Merged
Conversation
Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
Chengxuan
reviewed
Sep 2, 2026
| Confirmed bool `json:"confirmed,omitempty"` // when true, it means the confirmation list is complete and the transaction is confirmed | ||
| TargetConfirmationCount uint64 `json:"targetConfirmationCount"` // the target number of confirmations for this reconcile request | ||
| CurrentConfirmationCount uint64 `json:"currentConfirmationCount"` // the current number of confirmations for this reconcile request | ||
| Timestamp *ethtypes.HexUint64 `json:"timestamp,omitempty"` // the on-chain timestamp of the transaction's block - only populated in "full" chain tracking mode, since "light" mode never fetches a block |
Contributor
There was a problem hiding this comment.
Hi @davecrighton , the naming of the variable will need to be tightened up if it's being put at the top level.
As per my understanding, this is not when the transaction is confirmed, it's when the transaction is included in a block and subject to change if the chain forks etc.
TxnBlockTimestamp / ReceiptBlockTimestamp/ ReceiptTimestamp could be options for the name. ReceiptTimestamp would be my pick.
Another solution could be extending Confirmations []*ethrpc.MinimalBlockInfo to include the timestamps for each block to provide more detailed information.
Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface the block timestamp in the ConfirmationUpdateResult. Scope to full mode only since we do not get the block info in light mode.