enable declaring custom topics for ffi interface publish and ff publish api create - #1734
Conversation
Signed-off-by: Kaijun Zhang <kaijun1543111@gmail.com>
There was a problem hiding this comment.
Thanks @ka1ii - would love to understand if all the comments from @awrichar have been addressed kaleido-io#140
Along with that suggest:
- Updating the docs
- Handling empty topics passed in better
| APISubscriptionStartSequenceID = ffm("api.startsequenceid", "The sequence ID in the raw event stream to start indexing through events from. Leave blank to start indexing from the most recent events") | ||
| APISubscriptionEndSequenceID = ffm("api.endsequenceid", "The sequence ID in the raw event stream to stop indexing through events at. Leave blank to start indexing from the most recent events") | ||
|
|
||
| APICustomTopicsQueryParam = ffm("api.customTopicsQueryParam", "Custom topics for ordering definition broadcast messages") |
There was a problem hiding this comment.
Wouldn't call it query param, as it's past in at POST
Signed-off-by: Kaijun Zhang <kaijun1543111@gmail.com>
Signed-off-by: Kaijun Zhang <kaijun1543111@gmail.com>
|
will need to update the go.mod once the pr in firefly-common gets merged https://github.com/hyperledger-firefly/common/pull/233/changes |
awrichar
left a comment
There was a problem hiding this comment.
This change looks good to me (accepting the "topics" in the DTO body, but not persisting to the database).
|
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 209 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I've enabled the Codecov App so can ignore the above message |

Proposed changes
allow clients to declare custom topics for ffi interface publish and ff publish api create
Fixes #1725
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.