Skip to content

Guard costs[i] bounds in estimateAndAssignTxCost to fix panic under Go 1.27 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+80 −2
Closed

Guard costs[i] bounds in estimateAndAssignTxCost to fix panic under Go 1.27 #94

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f993b6b
Initial plan
Copilot Aug 14, 2026
a2e0008
Fix: guard costs[i] access in estimateAndAssignTxCost to prevent pani…
Copilot Aug 14, 2026
6ac68c5
Fix stack overflow under Go 1.27: bypass (*micheline.Parameters).Unma…
Copilot Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/tezos/prepare_transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ func (c *tezosConnector) estimateAndAssignTxCost(ctx context.Context, op *codec.
verb = "forced"
}
limits := v.Limits()
if i >= len(costs) {
log.L(ctx).Debugf("OP#%03d: %s fee(%s)=%d gas_limit(%s)=%d storage_limit(%s)=%d (no simulation cost data)",
i, v.Kind(), verb, limits.Fee, verb, limits.GasLimit, verb, limits.StorageLimit,
)
continue
}
log.L(ctx).Debugf("OP#%03d: %s gas_used(sim)=%d storage_used(sim)=%d storage_burn(sim)=%d alloc_burn(sim)=%d fee(%s)=%d gas_limit(%s)=%d storage_limit(%s)=%d ",
i, v.Kind(), costs[i].GasUsed, costs[i].StorageUsed, costs[i].StorageBurn, costs[i].AllocationBurn,
verb, limits.Fee, verb, limits.GasLimit, verb, limits.StorageLimit,
Expand Down
37 changes: 37 additions & 0 deletions internal/tezos/prepare_transaction_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,43 @@ func TestTransactionPrepareWithRevealEmptyServerError(t *testing.T) {
assert.Nil(t, resp)
}

func Test_estimateAndAssignTxCostFewerSimResultsThanOpContents(t *testing.T) {
ctx, c, mRPC, done := newTestConnector(t)
defer done()

// Simulate returns only one result, but the op has two contents entries.
// The bounds check should prevent an index-out-of-bounds panic for the second entry.
mRPC.On("Simulate", ctx, mock.Anything, mock.Anything).
Return(&rpc.Receipt{
Op: &rpc.Operation{
Contents: []rpc.TypedOperation{
rpc.Transaction{
Manager: rpc.Manager{
Generic: rpc.Generic{
Metadata: rpc.OperationMetadata{
Result: rpc.OperationResult{
Status: tezos.OpStatusApplied,
},
},
},
},
},
},
},
}, nil)

op := codec.NewOp()
txArgs := contract.TxArgs{}
op.WithContents(txArgs.Encode())
op.WithContents(txArgs.Encode()) // second entry has no corresponding simulation cost

opts := &rpc.DefaultOptions
opts.IgnoreLimits = true

_, err := c.estimateAndAssignTxCost(ctx, op, opts)
assert.NoError(t, err)
}

func Test_getNetworkParamsByName(t *testing.T) {
params := getNetworkParamsByName("ghostnet")
assert.Equal(t, params, tezos.GhostnetParams)
Expand Down
Loading