Skip to content

fix(cves): Upgrade JS YAML dep through NestJS Swagger - #210

Merged
EnriqueL8 merged 1 commit into
hyperledger-firefly:mainfrom
SamMayWork:fix-cves
Aug 7, 2026
Merged

fix(cves): Upgrade JS YAML dep through NestJS Swagger#210
EnriqueL8 merged 1 commit into
hyperledger-firefly:mainfrom
SamMayWork:fix-cves

Conversation

@SamMayWork

Copy link
Copy Markdown
Contributor

ref similar PR for erc1155: hyperledger-firefly/tokens-erc1155#186

Right now running npm audit shows the following output from main:

5 vulnerabilities (1 low, 4 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
Full output
# npm audit report

body-parser  2.0.0 - 2.2.2
body-parser vulnerable to denial of service when invalid limit value silently disables size enforcement - https://github.com/advisories/GHSA-v422-hmwv-36x6
fix available via `npm audit fix`
node_modules/body-parser

brace-expansion  4.0.0 - 5.0.8
Severity: high
brace-expansion: DoS via unbounded expansion length causing an out-of-memory process crash - https://github.com/advisories/GHSA-mh99-v99m-4gvg
brace-expansion: DoS via unbounded intermediate arrays, bypassing the CVE-2026-14257 mitigation - https://github.com/advisories/GHSA-rgw5-rvv9-x895
fix available via `npm audit fix`
node_modules/brace-expansion

fast-uri  3.0.0 - 3.1.4
Severity: high
fast-uri vulnerable to host confusion via literal backslash authority delimiter - https://github.com/advisories/GHSA-v2hh-gcrm-f6hx
fast-uri vulnerable to host confusion via backslash authority introducer - https://github.com/advisories/GHSA-7p8r-x3mc-p8w7
fix available via `npm audit fix`
node_modules/fast-uri

js-yaml  3.0.0 - 3.15.0 || 4.0.0 - 4.3.0
Severity: high
JS-YAML: Quadratic CPU consumption in !!omap resolution (3.x and 4.x) — CVE-2026-59870 fix not backported - https://github.com/advisories/GHSA-5p4m-2wfm-xmqj
JS-YAML: Quadratic CPU consumption in !!omap resolution (3.x and 4.x) — CVE-2026-59870 fix not backported - https://github.com/advisories/GHSA-5p4m-2wfm-xmqj
fix available via `npm audit fix`
node_modules/@istanbuljs/load-nyc-config/node_modules/js-yaml
node_modules/js-yaml
  @nestjs/swagger  5.3.0-next.1 - 11.4.5 || >=12.0.0-alpha.0
  Depends on vulnerable versions of js-yaml
  node_modules/@nestjs/swagger

5 vulnerabilities (1 low, 4 high)

To address all issues, run:
  npm audit fix

This PR proposes bumping the version of js-yaml from 5.2.1 to 5.2.3 because there is currently no patched version of @nestjs/swagger which resolves these vulnerabilities.

Signed-off-by: SamMayWork <sam.may@kaleido.io>
@SamMayWork
SamMayWork requested a review from a team as a code owner August 7, 2026 13:45
@SamMayWork

Copy link
Copy Markdown
Contributor Author

Verified no difference in the swagger endpoint

@EnriqueL8 EnriqueL8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SamMayWork

@EnriqueL8
EnriqueL8 merged commit 7993b30 into hyperledger-firefly:main Aug 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants