Init network with simple chaincode #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 8, 2021
Hejwo
requested changes
Mar 11, 2021
| @@ -49,7 +52,7 @@ describe('validate', () => { | |||
| expect(commandResult).toEqual(TestCommands.success()); | |||
| expect(commandResult.output).toContain('Validation errors count: 0'); | |||
| expect(commandResult.output).toContain('Validation warnings count: 0'); | |||
| expect(commands.getFiles()).toEqual(['./e2e/__tmp__/commands-tests/fabrica-config.json']); | |||
| expect(commands.getFiles()).toContain('./e2e/__tmp__/commands-tests/fabrica-config.json'); | |||
There was a problem hiding this comment.
hm... didn't quite get the case where:
- user first creates own chaincode in
chaincodes/chaincode-kv-node - then executes
fabrica init
What would happen then? Files will get overridden or we revive yeoman prompt?
(If it's not handled) Maybe he should get suitable prompt like: "chaincode already exists. It's advised to manually check if fabrica-config contains correctchaincode[0].lang " ?
dzikowski
force-pushed
the
issue-100/init-chaincode
branch
from
963c214 to
3ebeabd
Compare
Hejwo
approved these changes
Mar 17, 2021
dzikowski
pushed a commit
that referenced
this pull request
Mar 17, 2021
Init network with simple chaincode
Hejwo
pushed a commit
that referenced
this pull request
Nov 12, 2021
Init network with simple chaincode Signed-off-by: Piotr Hejwowski <[email protected]>
Hejwo
pushed a commit
that referenced
this pull request
Nov 13, 2021
Init network with simple chaincode Signed-off-by: Piotr Hejwowski <[email protected]>
dzikowski
pushed a commit
that referenced
this pull request
Nov 18, 2021
Init network with simple chaincode Signed-off-by: Jakub Dzikowski <[email protected]>
dzikowski
pushed a commit
that referenced
this pull request
Nov 18, 2021
Init network with simple chaincode Signed-off-by: Jakub Dzikowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.