Adapt to app-channel in perun-examples #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinnendo
changed the title
tinnendo
force-pushed
the
chore-update-to-goperun-0.11.0
branch
from
17e6db9
to
f31cf59
Compare
Signed-off-by: Hendrik Amler <[email protected]>
tinnendo
force-pushed
the
chore-update-to-goperun-0.11.0
branch
from
f31cf59
to
ada4367
Compare
iljabvh
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a critical issue with AppID handling that affected the Perun App Channel example. The issue was causing the example app to fail following the upgrade to v0.11.0 due to incompatible changes in the way AppID was managed.
Related Issue
This PR directly resolves an issue that occured in perun-examples PR #20.
With this fix, the examples in the perun-examples repository can now successfully run with go-perun v0.11.0.
Changes Made
Fix AppID Handling:
Replaced the previous AppID handling with channel.AppID.
Implemented the use of MarshalBinary() for extracting Ethereum addresses.
Verified the fix using the Perun App Channel example from the perun-examples repo, confirming that the issue with AppID has been resolved.