Resolve context.TODO() and add context argument #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abicky
force-pushed
the
use-context-appropriately
branch
2 times, most recently
from
b1c0ca7 to
f526dce
Compare
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
force-pushed
the
use-context-appropriately
branch
from
f526dce to
e71561e
Compare
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
force-pushed
the
use-context-appropriately
branch
from
e71561e to
6cdff2b
Compare
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
force-pushed
the
use-context-appropriately
branch
2 times, most recently
from
25566ea to
609e560
Compare
…tegyI Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
force-pushed
the
use-context-appropriately
branch
from
609e560 to
526ab84
Compare
Signed-off-by: Takeshi Arabiki <[email protected]>
To avoid the error "Cannot open: File exists" cf. https://github.com/orgs/community/discussions/58174 actions/setup-go v4 or later has its own caching mechanism, so we don't need actions/cache. Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
force-pushed
the
use-context-appropriately
branch
from
34f76fc to
0b719e8
Compare
Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
force-pushed
the
use-context-appropriately
branch
from
c4bc26f to
1df3281
Compare
siburu
approved these changes
Mar 4, 2025
| // NOTE: Although cosmos-sdk does not currently use CmdContext in Context.QueryWithData, | ||
| // set ctx to clientCtx in case cosmos-sdk uses it in the future. | ||
| // (cf. https://github.com/cosmos/cosmos-sdk/blob/v0.50.5/client/query.go#L98, https://github.com/cosmos/cosmos-sdk/blob/v0.50.5/x/auth/types/account_retriever.go#L39, etc.) | ||
| clientCtx := c.CLIContext(0).WithCmdContext(ctx) |
| ~/go/pkg/mod | ||
| key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-go- |
abicky
added a commit
to abicky/yui-relayer
that referenced
this pull request
Mar 28, 2025
This commit fixes the bug where some iterations skip calling `<-ticker.C` before proceeding to the next loop. This is a regression introduced in hyperledger-labs#154. Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
added a commit
to abicky/yui-relayer
that referenced
this pull request
Mar 28, 2025
This commit fixes the bug where some iterations skip calling `<-ticker.C` before proceeding to the next loop. This is a regression introduced in hyperledger-labs#154. Signed-off-by: Takeshi Arabiki <[email protected]>
abicky
added a commit
to abicky/yui-relayer
that referenced
this pull request
Mar 28, 2025
This commit fixes the bug where some iterations skip calling `<-ticker.C` before proceeding to the next loop. This is a regression introduced in hyperledger-labs#154. Signed-off-by: Takeshi Arabiki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the third phase and part of the fourth phase of the integration with OpenTelemetry described on #153.
In the first part of the commits, I have added a context argument to the methods called from various code and added
context.TODO()to each caller. I have also made the downstream methods (the methods called from the method) use the context argument appropriately and added a context argument if necessary.In the second part of the commits, I have replaced
context.TODO()withcmd.Context()in the cmd package and made the downstream methods use the context argument appropriately.In the following PRs (the fourth phase), I will do the same thing in other repositories.
Behavior changes
This PR also makes the relayer shutdown gracefully (526ab84) when it receives SIGINT and SIGTERM.
Here is the output from the relayer started by
service startwhen I pressed^C:Before
After
What I have checked
I have confirmed that there is no longer
context.TODO()as follows:I have also ensured that the CI passes in the following repositories: