Check released version and configured version #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently same version published and caused issues for the downstream applications with checksum changes. Added GitHub step check whether the version configured has been released previously. This will prevent overriding existing releases Signed-off-by: Chaminda Divitotawela <[email protected]>
macfarla
reviewed
Jul 30, 2024
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Chaminda Divitotawela <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Chaminda Divitotawela <[email protected]>
macfarla
approved these changes
Aug 1, 2024
jframe
approved these changes
Aug 1, 2024
|
This seems to have broken CI for releases. I am going to revert in the 0.9.4 release and we can come up with something else |
garyschulte
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit 5001ac8.
garyschulte
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit 5001ac8. Signed-off-by: garyschulte <[email protected]>
garyschulte
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit 5001ac8. Signed-off-by: garyschulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently same version published and caused issues for the downstream applications with checksum changes. Added GitHub step check whether the version configured has been released previously. This will prevent overriding existing releases
fixes consensys/protocol-misc#937