Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Update to gradle 8.11 #8294

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

macfarla
Copy link
Contributor

Signed-off-by: Sally MacFarlane [email protected]## PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla macfarla changed the title Update to gradle 8.11 [build] Update to gradle 8.11 Feb 13, 2025
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla
Copy link
Contributor Author

note the compileSolidity target failed with gradle 8.12 - but maybe with #8296 that would be fixed.

@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 14, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 14, 2025
@macfarla macfarla added this pull request to the merge queue Feb 14, 2025
@macfarla macfarla enabled auto-merge (squash) February 14, 2025 02:51
@macfarla
Copy link
Contributor Author

https://github.com/hyperledger/besu/actions/runs/13321506491/job/37206884944

> Task :acceptance-tests:tests:acceptanceTestNotPrivacy
The message received from the daemon indicates that the daemon has disappeared.
Build request sent: Build{id=b7a1d909-b470-426d-91b9-5716301a2d06, currentDir=/home/runner/work/besu/besu}
Attempting to read last messages from the daemon log...

Error: The operation was canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants