Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node 22 for chaincode Docker image #436

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Use Node 22 for chaincode Docker image #436

merged 1 commit into from
Nov 22, 2024

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Aug 22, 2024 •
edited
Loading

Closes #435

@bestbeforetoday bestbeforetoday marked this pull request as ready for review October 29, 2024 10:03
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner October 29, 2024 10:04
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) October 29, 2024 10:04
@bestbeforetoday
Copy link
Member Author

Waiting for a version of Node 22 (and accompanying Docker image) to be released that bundles npm 10.9.1 or later, due to bugs in npm and Node that can cause hangs (or at least very long delays) during dependency installation.

@bestbeforetoday bestbeforetoday merged commit b3720d0 into hyperledger:main Nov 22, 2024
8 checks passed
@denyeart
Copy link
Contributor

Waiting for a version of Node 22 (and accompanying Docker image) to be released that bundles npm 10.9.1 or later, due to bugs in npm and Node that can cause hangs (or at least very long delays) during dependency installation.

I approved but wasn't going to merge yet due to this comment. But the auto-merge kicked in. Did you intend to merge it at this time?

@bestbeforetoday bestbeforetoday deleted the node22 branch November 22, 2024 17:01
@bestbeforetoday
Copy link
Member Author

It's fine to merge now. I'll just want the new Node version to appear before publishing a release. A fixed npm version is already available, just not included in the Node Docker image yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denyeart denyeart denyeart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Node 22
2 participants
@bestbeforetoday @denyeart