config submitter part 3 #326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubmitter add config submitter tests to router fix some other tests Signed-off-by: Dor.Katzelnick <[email protected]>
HagarMeir
reviewed
Nov 2, 2025
node/router/stream.go
Outdated
| // TODO: forward request to batcher or consenter | ||
| _ = reqType | ||
| if reqType == common.HeaderType_CONFIG_UPDATE { | ||
| s.logger.Debugf("received request with type %s, forwarding to consenter", reqType) |
There was a problem hiding this comment.
This can be info and not debug if it is only for config requests
HagarMeir
reviewed
Nov 2, 2025
node/router/router_test.go
Outdated
| var wg sync.WaitGroup | ||
| wg.Add(1) | ||
|
|
||
| go func() { |
DorKatzelnick
force-pushed
the
configSubmitter3new
branch
from
4cb31e1 to
c5619f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #192