[log] WithLogFields for Configuring Larger Logging Contexts #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hfuss <[email protected]>
Signed-off-by: hfuss <[email protected]>
EnriqueL8
reviewed
May 15, 2024
| return WithLogger(ctx, loggerFromContext(ctx).WithField(key, value)) | ||
| } | ||
|
|
||
| func WithLogFields(ctx context.Context, keyValues ...string) context.Context { |
There was a problem hiding this comment.
Having ...string is fine to be consistent with WithLogField but it doesn't stop us having logrus.Fields one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several case, one might want to set several key value pairs on the context. Currently you have to chain together nested
WithLogFieldfuncs to do so, which isn't very readable or user friendly.This allows the users to do so with just a list of strings. Otherwise we could require a
logrus.Fieldsstruct to be directly provided if we want to avoid the odd-number-check-and-panic ?