chore: make testing more resilient and update docs #9278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded reliance on testutil for running simple commands as that package's init mechanism tries to communicate with Docker
Badger has its own repo and test scripts
Add more narrative; instructions for testing on OSX
matthewmcneely
requested review from
ryanfoxtyler and
mangalaman93
and removed request for
a team
github-actions
bot
added
area/testing
Seeing this issue occasionally
=== RUN TestLoaderXidmap
client.go:222:
Error Trace: /home/runner/work/dgraph/dgraph/testutil/client.go:222
/home/runner/work/dgraph/dgraph/systest/loader/loader_test.go:49
Error: Received unexpected error:
rpc error: code = Unavailable desc = connection error: desc = "error reading server preface: remote error: tls: certificate required"
Test: TestLoaderXidmap
--- FAIL: TestLoaderXidmap (0.01s)
|
@ryanfoxtyler The test failures are the "usual suspects"... this PR adds some improvements in resiliency (but not enough I guess!). But the docs are the most important improvements. |
mangalaman93
previously approved these changes
Jan 16, 2025
github-actions
bot
added
area/enterprise
mangalaman93
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates testing code to make testing easier on non-Linux environments and fix some commonly failing tests. It also more thoroughly documents the
tframework as well as offering guidance on other tests.Checklist