feat: add modusdb model tracing for local dev #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairad26
changed the title
…f github.com:hypermodeinc/modus into jai/hyp-2609-move-local-inference-history-to-modusdb
Comment on lines
+22
to
+30
| func InitModusDb(ctx context.Context) { | ||
| // Initialize the database connection. | ||
| var err error | ||
| GlobalModusDbEngine, err = modusdb.NewEngine(modusdb.NewDefaultConfig(dataDir)) | ||
| if err != nil { | ||
| logger.Fatal(ctx).Err(err).Msg("Failed to initialize modusdb.") | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
We should only be initializing Modus DB in development, and we should use the Modus home directory for the root of the storage. Consider:
Suggested change
| func InitModusDb(ctx context.Context) { | |
| // Initialize the database connection. | |
| var err error | |
| GlobalModusDbEngine, err = modusdb.NewEngine(modusdb.NewDefaultConfig(dataDir)) | |
| if err != nil { | |
| logger.Fatal(ctx).Err(err).Msg("Failed to initialize modusdb.") | |
| return | |
| } | |
| } | |
| func InitModusDb(ctx context.Context) { | |
| if config.IsDevEnvironment() { | |
| dataDir := filepath.Join(app.ModusHomeDir(), "data") | |
| if eng, err := modusdb.NewEngine(modusdb.NewDefaultConfig(dataDir)); err != nil { | |
| logger.Fatal(ctx).Err(err).Msg("Failed to initialize modusdb.") | |
| } else { | |
| GlobalModusDbEngine = eng | |
| } | |
| } | |
| } |
You can add the following to /runtime/app/app.go:
func ModusHomeDir() string {
modusHome := os.Getenv("MODUS_HOME")
if modusHome == "" {
userHome, _ := os.UserHomeDir()
modusHome = filepath.Join(userHome, ".modus")
}
return modusHome
}
| @@ -0,0 +1,36 @@ | |||
| /* | |||
| * Copyright 2024 Hypermode Inc. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright 2024 Hypermode Inc. | |
| * Copyright 2025 Hypermode Inc. |
| @@ -0,0 +1,401 @@ | |||
| /* | |||
| * Copyright 2024 Hypermode Inc. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright 2024 Hypermode Inc. | |
| * Copyright 2025 Hypermode Inc. |
| @@ -38,7 +38,7 @@ func parseCommandLineFlags() { | |||
| var showVersion bool | |||
| const versionUsage = "Show the Runtime version number and exit." | |||
| flag.BoolVar(&showVersion, "version", false, versionUsage) | |||
| flag.BoolVar(&showVersion, "v", false, versionUsage+" (shorthand)") | |||
| // flag.BoolVar(&showVersion, "v", false, versionUsage+" (shorthand)") | |||
There was a problem hiding this comment.
Discussed. I will address separately to remove global flagset usage.
| @@ -3,3 +3,5 @@ runtime | |||
|
|
|||
| node_modules | |||
| dist | |||
|
|
|||
There was a problem hiding this comment.
This shouldn't be needed.
Comment on lines
+142
to
+143
| defaultRoutes["/inferences.json"] = InferenceHistoryHandler | ||
| defaultRoutes["/plugins.json"] = PluginHandler |
There was a problem hiding this comment.
This feels weird. Let's discuss.
There was a problem hiding this comment.
Per our discussion:
- Move
/inferences.jsonand the correspondinginferenceHistoryHandlertoexplorer/explorer.goand connect it there as/explorer/api/inferences(no.jsonextension). Wire it to the explorer's own mux, and update the explorermain.tsxto use it. - Remove
/plugins.jsonsince we're not using it in the explorer
Comment on lines
+277
to
+278
| j, _ := utils.JsonSerialize(inferences) | ||
| _, _ = w.Write(j) |
There was a problem hiding this comment.
check these errors please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
All PRs should check the following boxes:
Conventional Commits syntax, leading with
fix:,feat:,chore:,ci:, etc.the contributing guide.
If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)
CHANGELOG.mdfile.