add Dirac GOS for EELS quantification #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
|
Thank you @zezhong-zhang for the pull request. We need a release of eXSpy before merging this PR - without the release, the notebook are failing when using the Dirac GOS. The changes look good, maybe a few tweaks but we can do this once eXSpy has been released with the Dirac GOS. |
|
Thanks @ericpre, no worries, we can finalise the tweaks after the exspy release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in hyperspy/hyperspy#3399 (reply in thread), here adds the examples for using Dirac GOS for EELS quantification. It includes:
This is done in a very simple manner of passing
GOSparameter during model creation and re-use of the previous quantification procedure and code (in a single jupyter cell), as I think the main purpose of the notebooks are showing users how to use exspy for quantification instead of detailed explanation of the GOS, but please let me know if further details are needed.