Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy-paste errors in backoff #1003

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

bertm
Copy link
Contributor

@bertm bertm commented Nov 17, 2024

From what I can understand from the logic, this would cause transfer backoff to not be taken into account for bulk.

  • The realtime parameter of getRoutingBackedOffUntil was set to true for both realtime and bulk.
  • The bulk backoff parameter in getPeerNodeStatus was not used due to it having the wrong name (the equally named field was used instead).

Fixes db3329d

These have been around since 2011.

* The realtime parameter of getRoutingBackedOffUntil was set to `true`
  for both realtime and bulk.
* The bulk backoff parameter in getPeerNodeStatus was not used due to
  it having the wrong name (the equally named field was used instead).

Fixes db3329d
@ArneBab
Copy link
Contributor

ArneBab commented Nov 19, 2024

That’s a frighteningly good catch! Seeing your fix I wondered how this could have worked at all. The answer seems to be that if routingBackedOffUntilBulk was not set, it fell back on transferBackedOffUntilBulk:

        public synchronized long getRoutingBackedOffUntilBulk() {
		return Math.max(routingBackedOffUntilBulk, transferBackedOffUntilBulk);
	}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants