Enable many more Ruff linter rules #9283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
force-pushed
the
enable-ruff-rules
branch
from
84797ae to
459130a
Compare
seanh
commented
Feb 6, 2025
Comment on lines
+1
to
+6
| "PT006", # Enforces a consistent style for the type of the `argnames` parameter to | ||
| # pytest.mark.parametrize. We have too many pre-existing violations of | ||
| # this. | ||
| "PT007", # Enforces a consistent style for the type of the `argvalues` parameter to | ||
| # pytest.mark.parametrize. We have too many pre-existing violations of | ||
| # this. |
There was a problem hiding this comment.
We can send a separate PR to remove these later, just trying to control the size of the diff right now.
This isn't needed (it's always run with commands like `python run_data_task.py`) and Ruff complains if executable files don't have a shebang.
seanh
commented
Feb 6, 2025
| @@ -60,18 +60,18 @@ def main(): | |||
| ) | |||
There was a problem hiding this comment.
Note that I've removed the executable bit from run_data_task.py. Ruff complains if a file is marked as executable that doesn't have a shebang line. It always seems to be run as python bin/run_data_task.py so the executable bit isn't needed
|
Closing in favour of #9328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.