fix(null): handle nullable postcode and state ZNA (#2)

hyraiq · Apr 20, 2023 · 5753351 · 5753351
1 parent bb6e9f9
commit 5753351
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/Model/AbnResponse.php b/src/Model/AbnResponse.php
@@ -30,12 +30,10 @@ final class AbnResponse extends AbstractResponse
     public \DateTimeImmutable $addressDate;
 
     #[SerializedName('AddressPostcode')]
-    #[NotBlank]
-    public string $addressPostcode;
+    public ?string $addressPostcode;
 
     #[SerializedName('AddressState')]
-    #[NotBlank]
-    public string $addressState;
+    public ?string $addressState;
 
     /**
      * @var string[]

diff --git a/tests/Model/AbnResponseTest.php b/tests/Model/AbnResponseTest.php
@@ -47,6 +47,14 @@ public function getValidTests(): \Generator
         $fields        = MockAbnResponse::valid();
         $fields['Gst'] = null;
         yield 'no gst' => [$fields];
+
+        $fields                 = MockAbnResponse::valid();
+        $fields['AddressState'] = null;
+        yield 'no address state' => [$fields];
+
+        $fields                    = MockAbnResponse::valid();
+        $fields['AddressPostcode'] = null;
+        yield 'no AddressPostcode' => [$fields];
     }
 
     /**
@@ -85,8 +93,6 @@ public function getInvalidTests(): \Generator
             'AbnStatus',
             'AbnStatusEffectiveFrom',
             'AddressDate',
-            'AddressPostcode',
-            'AddressState',
             'EntityName',
             'EntityTypeCode',
             'EntityTypeName',