Skip to content

Commit

Permalink
Fix not blank on addressDate property (#7)
Browse files Browse the repository at this point in the history
Fix for previous release that didn’t actually fix the issue as it still
didn’t allow a null `addressDate`
  • Loading branch information
kielabokkie authored Jul 3, 2023
1 parent 6805d7f commit 9a769c6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion src/Model/AbnResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ final class AbnResponse extends AbstractResponse
public ?string $acn = null;

#[SerializedName('AddressDate')]
#[NotBlank]
public ?\DateTimeImmutable $addressDate = null;

#[SerializedName('AddressPostcode')]
Expand Down
2 changes: 1 addition & 1 deletion src/Stubs/MockAbnResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public static function valid(): array
'AbnStatus' => 'Active',
'AbnStatusEffectiveFrom' => '2017-07-24',
'Acn' => '620650553',
'AddressDate' => '2017-07-24',
'AddressDate' => null,
'AddressPostcode' => '4000',
'AddressState' => 'QLD',
'BusinessName' => [
Expand Down
1 change: 0 additions & 1 deletion tests/Model/AbnResponseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ public function getInvalidTests(): \Generator
'Abn',
'AbnStatus',
'AbnStatusEffectiveFrom',
'AddressDate',
'EntityName',
'EntityTypeCode',
'EntityTypeName',
Expand Down

0 comments on commit 9a769c6

Please sign in to comment.