Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatter): add ABN formatter function #8

Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat(formatter): add ABN formatter function #8

merged 1 commit into from
Sep 26, 2023

Conversation

pm0
Copy link
Contributor

@pm0 pm0 commented Sep 26, 2023

Function takes an ABN string and returns it with spaces.

e.g. AbnFormatter::format('30616935623') -> '30 616 935 623'

Copy link
Contributor

@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I forget how to publish new versions of this to packagist though. Might need to get Wouter's help.

Copy link
Contributor

@kielabokkie kielabokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍🏼

Once this is merged you'll have to go to the releases page and create a new release to make sure it gets published to packagist.

@pm0 pm0 merged commit f0ee793 into main Sep 26, 2023
6 checks passed
@pm0 pm0 deleted the abn-formatter branch September 26, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants