Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schema valid #129

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Make schema valid #129

merged 8 commits into from
Sep 27, 2023

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Sep 25, 2023

Uploading a workflow with a pdb file that can not be parsed by https://github.com/douweschulte/pdbtbx would cause a invalid JSON schema to be generated, which in turn made the upload fail to be loaded.

Workflow builder gives:

chunk-NW63JG7V.js:28 Error: schema is invalid: data/properties/mol/items must be object,boolean, data/properties/mol/items/0/properties/hisd/items/enum must NOT have fewer than 1 items, data/properties/mol/items/0/properties/hisd/items must be array, data/properties/mol/items/0/properties/hisd/items must match a schema in anyOf, data/properties/mol/items must match a schema in anyOf
    at Ajv3.validateSchema (core.ts:519:18)
    at Ajv3._addSchema (core.ts:721:30)
    at Ajv3.compile (core.ts:384:22)
    at Ajv3.validate (core.ts:361:16)
    at validateParameters (chunk-GRSI6OON.js:67:12)
    at chunk-GRSI6OON.js:45:26
    at Array.map (<anonymous>)
    at validateWorkflow (chunk-GRSI6OON.js:32:38)
    at async loadWorkflowArchive (chunk-CFUCBIDV.js:25:18)
    at async loadWorkflowArchive (chunk-UMXYOHQW.js:343:17)

This PR fixes this error.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for i-vresse-workflow-builder ready!

Name Link
🔨 Latest commit 30a8cbd
🔍 Latest deploy log https://app.netlify.com/sites/i-vresse-workflow-builder/deploys/651403075a197f00083b8eee
😎 Deploy Preview https://deploy-preview-129--i-vresse-workflow-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #129 (1a90151) into main (e7fbcac) will increase coverage by 0.01%.
The diff coverage is 75.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   66.62%   66.64%   +0.01%     
==========================================
  Files          57       57              
  Lines        4033     4035       +2     
  Branches      332      334       +2     
==========================================
+ Hits         2687     2689       +2     
+ Misses       1343     1342       -1     
- Partials        3        4       +1     
Flag Coverage Δ
core-unit 63.64% <75.00%> (+0.02%) ⬆️
form-unit 78.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/core/src/molecule/addMoleculeValidation.ts 92.85% <75.00%> (+0.04%) ⬆️

@sverhoeven sverhoeven marked this pull request as ready for review September 26, 2023 06:51
sverhoeven and others added 5 commits September 27, 2023 08:15
Following changes to the defaults.yaml will not cause reordering of modules in the catalog.
Which will make it easier to see what changes where actually made.

Modules taken from https://github.com/haddocking/haddock3/tree/interactive_rescoring merged with haddocking/haddock3@bedbf25
@sverhoeven sverhoeven merged commit b35102e into main Sep 27, 2023
4 of 5 checks passed
@sverhoeven sverhoeven deleted the valid-schema branch September 27, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants