-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove css-in-js button styles from core #139
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2f11656
refactor: remove css-in-js styles defined using @emotion. @emotion de…
dmijatovic 0574b0d
feat: apply style changes from core to download example
dmijatovic 63d6b86
refactor: improve dnd button size and drop area
dmijatovic 543aea3
Fix lint error
sverhoeven c0abb7a
refactor: add form styles to example apps
dmijatovic b516156
fix: use unique node ids for dnd
dmijatovic 41b32a2
fix: example styles based on PR feedback
dmijatovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,120 @@ | ||
| /* | ||
| Customise workflow builder components | ||
| */ | ||
|
|
||
| .page { | ||
| padding: 1em; | ||
| display: grid; | ||
| width: 100%; | ||
| height: 100vh; | ||
| grid-template-areas: "head head head" | ||
| "catalog workflow node" | ||
| "catalog workflow-actions node-actions"; | ||
| grid-template-columns: 1fr 1fr 2fr; | ||
| grid-template-rows: auto 1fr auto; | ||
| column-gap: 0.5rem; | ||
| padding: 1em; | ||
| display: grid; | ||
| width: 100%; | ||
| height: 100vh; | ||
| grid-template-areas: "head head head" | ||
| "catalog workflow node" | ||
| "catalog workflow-actions node-actions"; | ||
| grid-template-columns: min-content minmax(12rem,1fr) minmax(20rem,2fr); | ||
| grid-template-rows: auto 1fr auto; | ||
| column-gap: 1rem; | ||
| } | ||
|
|
||
| /* Style workflow area section */ | ||
| .workflow-area { | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| /* Style various form buttons */ | ||
| .btn { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| gap: 1rem; | ||
| } | ||
|
|
||
| .btn-visual-panel, | ||
| .btn-catalog-node { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .btn-group { | ||
| display: flex; | ||
| gap: 0.5rem; | ||
| } | ||
|
|
||
| /* remove gap from dropdown group */ | ||
| .dropdown.btn-group { | ||
| gap: 0rem; | ||
| } | ||
|
|
||
| /* center + icon in the button */ | ||
| .array-item-add{ | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .no-wrap{ | ||
| text-wrap: nowrap; | ||
| } | ||
|
|
||
| ul{ | ||
| padding: 0.25rem 0.25rem 0.25rem 1.25rem; | ||
| } | ||
|
|
||
| .page > div { | ||
| overflow: auto; | ||
| li{ | ||
| list-style-type: none; | ||
| } | ||
|
|
||
| .action-row { | ||
| padding: 0.25rem | ||
| li > ul{ | ||
| padding: 0rem; | ||
| } | ||
|
|
||
| div[role="button"], | ||
| .btn-catalog-node{ | ||
| margin: 0.5rem 0rem; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| /* Format actions section at the bottom */ | ||
| .action-row, | ||
| .action-row>.nav { | ||
| display: flex; | ||
| gap: 1rem; | ||
| padding: 0.25rem; | ||
| } | ||
|
|
||
| .action-row>.nav { | ||
| flex: 1; | ||
| justify-content: flex-end; | ||
| } | ||
|
|
||
|
|
||
| .btn-toolbar{ | ||
| display: flex; | ||
| gap: 1rem; | ||
| padding: 1rem 0rem; | ||
| } | ||
|
|
||
| /* Show panel section is clickable */ | ||
| h5[id^="expander4"]{ | ||
| cursor: pointer; | ||
| } | ||
| /* Allow scrollbars in the card when content is too large */ | ||
| .card-body{ | ||
| overflow: auto; | ||
| } | ||
|
|
||
| /* Alow scrollbars on tables which exceed card width */ | ||
| .form-group > fieldset { | ||
| overflow: auto; | ||
| } | ||
|
|
||
| /* hide commands by default */ | ||
| .btn-catalog-node .grip, | ||
| .btn-visual-node .btn-group{ | ||
| visibility: hidden; | ||
| } | ||
|
|
||
| /* show commands on hover */ | ||
| .btn-catalog-node:hover .grip, | ||
| .btn-visual-node:hover .btn-group { | ||
| visibility: visible; | ||
| } | ||
dmijatovic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,122 @@ | ||
| /* | ||
| Customise workflow builder components | ||
| NOTE! copy of apps/haddock3-download/src/App.css | ||
| */ | ||
|
|
||
| .page { | ||
| padding: 1em; | ||
| display: grid; | ||
| width: 100%; | ||
| height: 100vh; | ||
| grid-template-areas: "head head head" | ||
| "catalog workflow node" | ||
| "catalog workflow-actions node-actions"; | ||
| grid-template-columns: 1fr 1fr 2fr; | ||
| "catalog workflow node" | ||
| "catalog workflow-actions node-actions"; | ||
| grid-template-columns: min-content minmax(12rem, 1fr) minmax(20rem, 2fr); | ||
| grid-template-rows: auto 1fr auto; | ||
| column-gap: 0.5rem; | ||
| column-gap: 1rem; | ||
| } | ||
|
|
||
| .page > div { | ||
| overflow: auto; | ||
| /* Style workflow area section */ | ||
| .workflow-area { | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| /* Style various form buttons */ | ||
| .btn { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| gap: 1rem; | ||
| } | ||
|
|
||
| .btn-visual-panel, | ||
| .btn-catalog-node { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .btn-group { | ||
| display: flex; | ||
| gap: 0.5rem; | ||
| } | ||
|
|
||
| /* remove gap from dropdown group */ | ||
| .dropdown.btn-group { | ||
| gap: 0rem; | ||
| } | ||
|
|
||
| /* center + icon in the button */ | ||
| .array-item-add { | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .no-wrap { | ||
| text-wrap: nowrap; | ||
| } | ||
|
|
||
| .page > .action-row { | ||
| ul { | ||
| padding: 0.25rem 0.25rem 0.25rem 1.25rem; | ||
| } | ||
|
|
||
| li { | ||
| list-style-type: none; | ||
| } | ||
|
|
||
| li>ul { | ||
| padding: 0rem; | ||
| } | ||
|
|
||
| div[role="button"], | ||
| .btn-catalog-node { | ||
| margin: 0.5rem 0rem; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| /* Format actions section at the bottom */ | ||
| .action-row, | ||
| .action-row>.nav { | ||
| display: flex; | ||
| gap: 1rem; | ||
| padding: 0.25rem; | ||
| overflow: unset; | ||
| } | ||
|
|
||
| .action-row>.nav { | ||
| flex: 1; | ||
| justify-content: flex-end; | ||
| } | ||
|
|
||
|
|
||
| .btn-toolbar { | ||
| display: flex; | ||
| gap: 1rem; | ||
| padding: 1rem 0rem; | ||
| } | ||
|
|
||
| /* Show panel section is clickable */ | ||
| h5[id^="expander4"] { | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| /* Allow scrollbars in the card when content is too large */ | ||
| .card-body { | ||
| overflow: auto; | ||
| } | ||
|
|
||
| /* Alow scrollbars on tables which exceed card width */ | ||
| .form-group>fieldset { | ||
| overflow: auto; | ||
| } | ||
|
|
||
| /* hide commands by default */ | ||
| .btn-catalog-node .grip, | ||
| .btn-visual-node .btn-group { | ||
| visibility: hidden; | ||
| } | ||
|
|
||
| /* show commands on hover */ | ||
| .btn-catalog-node:hover .grip, | ||
| .btn-visual-node:hover .btn-group { | ||
| visibility: visible; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
.panel-titleclass instead of id begins with selector? Or is the class used elsewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"panel-title" class is not used in all panels :-(. This is the only selector I found that works for all collapsible panels.