Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When upload has errors show them to user #143

Merged
merged 3 commits into from
Mar 22, 2024
Merged

When upload has errors show them to user #143

merged 3 commits into from
Mar 22, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Mar 22, 2024 •
edited
Loading

Before the error would be logged to devtools console.
Now it is shown to user:
localhost_3000_ (1)

@netlify Netlify
Copy link

netlify bot commented Mar 22, 2024 •
edited
Loading

✅ Deploy Preview for i-vresse-workflow-builder ready!

Name Link
🔨 Latest commit ee5bb4d
🔍 Latest deploy log https://app.netlify.com/sites/i-vresse-workflow-builder/deploys/65fd599949d1c40008b4dd1d
😎 Deploy Preview https://deploy-preview-143--i-vresse-workflow-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sverhoeven sverhoeven marked this pull request as ready for review March 22, 2024 10:02
dmijatovic
dmijatovic approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@dmijatovic dmijatovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sverhoeven
Copy link
Member Author

thanks for reviewing

@sverhoeven sverhoeven merged commit 2081526 into main Mar 22, 2024
5 checks passed
@sverhoeven sverhoeven deleted the render-upload-errors branch March 22, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmijatovic dmijatovic dmijatovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverhoeven @dmijatovic