fix: unexpected error when removing uploaded molecule file #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for i-vresse-workflow-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sverhoeven
approved these changes
May 21, 2024
There was a problem hiding this comment.
Tested the netlify and cancelling file now behaves as expected.
The test could be improved by
- Make it easier to read by using a mockGlobalSchema with only the molecules property.
- 2 use cases (undefined and null) are tested in same test, would be nice to use 2 tests or a parameterized test so each use case can fail/succeed independently of each other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: error when removing uploaded molecule file
The validation of passed file values is extend to check on undefined and null entries in the molecules array.