Skip to content

fix(cli): forward port 4318 (OTLP) from VM to host#2285

Merged
jezekra1 merged 2 commits intomainfrom
fix/forward-port-4318
Mar 4, 2026
Merged

fix(cli): forward port 4318 (OTLP) from VM to host#2285
jezekra1 merged 2 commits intomainfrom
fix/forward-port-4318

Conversation

@jezekra1
Copy link
Collaborator

@jezekra1 jezekra1 commented Mar 4, 2026

Summary

  • Add port 4318 to the VM-to-host port forwarding rules so the OpenTelemetry (OTLP) collector endpoint is accessible from the host

Test plan

  • Verify platform start forwards port 4318 alongside the 8333-8399 range

Add port 4318 to the port forwarding rules so that the OpenTelemetry
collector endpoint is accessible from the host.

Signed-off-by: Radek Ježek <radek.jezek@ibm.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 4, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an accessibility issue for the OpenTelemetry (OTLP) collector endpoint. By modifying the port forwarding rules, it ensures that the OTLP collector, which uses port 4318, is properly exposed from the virtual machine to the host system. This change is crucial for developers and systems needing to interact with or collect data from the OTLP endpoint running within the VM environment.

Highlights

  • OTLP Port Forwarding: Enabled forwarding of port 4318 from the VM to the host, making the OpenTelemetry (OTLP) collector endpoint accessible.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • apps/agentstack-cli/src/agentstack_cli/commands/platform.py
    • Updated the port forwarding logic to include port 4318 for OTLP.
Activity
  • The author included a test plan to verify platform start forwards port 4318 alongside the existing port range.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds port forwarding for the OTLP port 4318. My review includes a suggestion to improve the shell script syntax for better performance and readability by avoiding the creation of an unnecessary subshell.

@jezekra1 jezekra1 merged commit e1814e9 into main Mar 4, 2026
9 of 11 checks passed
@jezekra1 jezekra1 deleted the fix/forward-port-4318 branch March 4, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant