Skip to content

Fix CVE-2026-25639: Upgrade axios to patch DoS vulnerability#2316

Merged
JanPokorny merged 2 commits intomainfrom
claude/fix-axios-vulnerability-SWd0B
Mar 9, 2026
Merged

Fix CVE-2026-25639: Upgrade axios to patch DoS vulnerability#2316
JanPokorny merged 2 commits intomainfrom
claude/fix-axios-vulnerability-SWd0B

Conversation

@JanPokorny
Copy link
Collaborator

Summary

Upgrades axios to version 1.13.5 to fix CVE-2026-25639 / GHSA-43fc-jf86-j433, a Denial of Service vulnerability in the mergeConfig function via __proto__ pollution. This dependency is pulled in transitively through mintlify → @mintlify/models.

Linked Issues

Documentation

  • No Docs Needed: This is a security patch with no user-facing changes or API modifications.

https://claude.ai/code/session_01GLM4n32m9BteVShuNZ48ob

Adds a pnpm override to force axios >= 1.0.0 <= 1.13.4 to 1.13.5, which
fixes the denial-of-service vulnerability (GHSA-43fc-jf86-j433) where
mergeConfig crashes with a TypeError when processing objects with __proto__
as an own property. Both transitive 1.10.0 and 1.13.2 versions (via
mintlify -> @mintlify/models) are now resolved to the patched 1.13.5.

https://claude.ai/code/session_01GLM4n32m9BteVShuNZ48ob
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing security by resolving a critical Denial of Service vulnerability in the axios library. The primary change involves upgrading axios to a patched version and ensuring this update is applied across all relevant transitive dependencies through explicit pnpm overrides. This proactive measure safeguards the application against potential exploits without introducing any user-facing changes or API modifications.

Highlights

  • Security Fix: Upgraded the axios package to version 1.13.5 to patch CVE-2026-25639 (GHSA-43fc-jf86-j433), which addresses a Denial of Service vulnerability related to __proto__ pollution in the mergeConfig function.
  • Dependency Management: Implemented a pnpm override in pnpm-workspace.yaml and pnpm-lock.yaml to explicitly force the axios version to 1.13.5 for all transitive dependencies, including @mintlify/models.
  • Minor Dependency Update: Updated the @carbon/react dependency version from 1.101.0 to 1.102.0 in the lockfile.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pnpm-lock.yaml
    • Updated @carbon/react dependency version from 1.101.0 to 1.102.0.
    • Added an explicit axios version override for versions between 1.0.0 and 1.13.4 to 1.13.5.
    • Removed old axios package resolutions (1.10.0 and 1.13.2) and added the new resolution for axios@1.13.5.
    • Updated @mintlify/models dependencies to reference the new axios@1.13.5 version.
  • pnpm-workspace.yaml
    • Added a pnpm override entry to force axios versions between 1.0.0 and 1.13.4 to use 1.13.5, along with a comment explaining the security fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a security vulnerability in axios by upgrading it. However, the review identified several critical inconsistencies with the vulnerability information and the axios versions being used. The CVE ID in pnpm-workspace.yaml is incorrect, and the specified vulnerability (GHSA-43fc-jf86-j433) does not seem to apply to the versions of axios currently in use. Furthermore, the axios versions themselves do not appear to be official releases. Due to these issues, the necessity and correctness of this change are questionable, and it is recommended to either provide correct vulnerability details or remove the change.

Comment on lines +5 to +7
# Fix CVE-2026-25639 / GHSA-43fc-jf86-j433: axios DoS via __proto__ in mergeConfig
# Transitive via mintlify -> @mintlify/models
"axios@>=1.0.0 <=1.13.4": "1.13.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There are critical inconsistencies in the vulnerability information provided, which questions the validity of this change.

  1. Incorrect CVE ID: The CVE ID CVE-2026-25639 is incorrect. The linked GHSA GHSA-43fc-jf86-j433 corresponds to CVE-2023-45857.

  2. Vulnerability Applicability: GHSA-43fc-jf86-j433 affects axios versions < 1.7.0. Your project uses axios versions 1.10.0 and 1.13.2, which are not vulnerable according to this advisory.

  3. Non-standard Versions: The axios versions in use (1.10.0, 1.13.2) and the target version (1.13.5) do not appear to be official axios releases. The latest official version is 1.7.2.

This override appears to be based on incorrect information and may be unnecessary. If another vulnerability is being addressed, please update the comment with the correct details. Otherwise, this override should be removed to avoid confusion and potential issues.

Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
@JanPokorny JanPokorny merged commit 39e4854 into main Mar 9, 2026
6 of 7 checks passed
@JanPokorny JanPokorny deleted the claude/fix-axios-vulnerability-SWd0B branch March 9, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants