Fix CVE-2026-25639: Upgrade axios to patch DoS vulnerability#2316
Fix CVE-2026-25639: Upgrade axios to patch DoS vulnerability#2316JanPokorny merged 2 commits intomainfrom
Conversation
Adds a pnpm override to force axios >= 1.0.0 <= 1.13.4 to 1.13.5, which fixes the denial-of-service vulnerability (GHSA-43fc-jf86-j433) where mergeConfig crashes with a TypeError when processing objects with __proto__ as an own property. Both transitive 1.10.0 and 1.13.2 versions (via mintlify -> @mintlify/models) are now resolved to the patched 1.13.5. https://claude.ai/code/session_01GLM4n32m9BteVShuNZ48ob
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing security by resolving a critical Denial of Service vulnerability in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix a security vulnerability in axios by upgrading it. However, the review identified several critical inconsistencies with the vulnerability information and the axios versions being used. The CVE ID in pnpm-workspace.yaml is incorrect, and the specified vulnerability (GHSA-43fc-jf86-j433) does not seem to apply to the versions of axios currently in use. Furthermore, the axios versions themselves do not appear to be official releases. Due to these issues, the necessity and correctness of this change are questionable, and it is recommended to either provide correct vulnerability details or remove the change.
| # Fix CVE-2026-25639 / GHSA-43fc-jf86-j433: axios DoS via __proto__ in mergeConfig | ||
| # Transitive via mintlify -> @mintlify/models | ||
| "axios@>=1.0.0 <=1.13.4": "1.13.5" |
There was a problem hiding this comment.
There are critical inconsistencies in the vulnerability information provided, which questions the validity of this change.
-
Incorrect CVE ID: The CVE ID
CVE-2026-25639is incorrect. The linked GHSAGHSA-43fc-jf86-j433corresponds toCVE-2023-45857. -
Vulnerability Applicability:
GHSA-43fc-jf86-j433affectsaxiosversions< 1.7.0. Your project usesaxiosversions1.10.0and1.13.2, which are not vulnerable according to this advisory. -
Non-standard Versions: The
axiosversions in use (1.10.0,1.13.2) and the target version (1.13.5) do not appear to be officialaxiosreleases. The latest official version is1.7.2.
This override appears to be based on incorrect information and may be unnecessary. If another vulnerability is being addressed, please update the comment with the correct details. Otherwise, this override should be removed to avoid confusion and potential issues.
Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
Summary
Upgrades axios to version 1.13.5 to fix CVE-2026-25639 / GHSA-43fc-jf86-j433, a Denial of Service vulnerability in the
mergeConfigfunction via__proto__pollution. This dependency is pulled in transitively through mintlify → @mintlify/models.Linked Issues
Documentation
https://claude.ai/code/session_01GLM4n32m9BteVShuNZ48ob