Fix CVE-2026-29074: Update SVGO to patch Billion Laughs DoS#2319
Fix CVE-2026-29074: Update SVGO to patch Billion Laughs DoS#2319JanPokorny merged 2 commits intomainfrom
Conversation
Add pnpm override to force svgo>=3.0.0,<3.3.3 to resolve to 3.3.3, patching GHSA-xpqw-6gx7-v673 (Billion Laughs entity expansion DoS). https://claude.ai/code/session_016832ktirXfL5q5vC5P8Fmj
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's security posture by patching a critical Denial of Service vulnerability. It ensures that a specific version of a key dependency is used, thereby safeguarding against potential attacks without introducing any functional changes or requiring documentation updates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the security vulnerability GHSA-xpqw-6gx7-v673 by updating the svgo dependency to version 3.3.3 using a pnpm override. The changes in pnpm-lock.yaml are consistent with this update. I've added a comment to correct a typo in the CVE number within pnpm-workspace.yaml. Please note that the same typo (CVE-2026-29074 instead of CVE-2024-29074) is present in the pull request title and description, which you may also want to correct for clarity and accurate tracking.
| # Fix CVE-2024-45296 / GHSA-9wv6-86v2-598j: path-to-regexp ReDoS vulnerability | ||
| # Transitive via mintlify -> @mintlify/previewing -> express@4.18.2 | ||
| "path-to-regexp@<0.1.10": "0.1.10" | ||
| # Fix CVE-2026-29074 / GHSA-xpqw-6gx7-v673: SVGO DoS through entity expansion in DOCTYPE (Billion Laughs) |
Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
Summary
Updates the SVGO dependency to version 3.3.3 to fix CVE-2026-29074 / GHSA-xpqw-6gx7-v673, a Denial of Service vulnerability through entity expansion in DOCTYPE (Billion Laughs attack). This vulnerability is transitive via @svgr/webpack → @svgr/plugin-svgo → svgo.
Linked Issues
Documentation
https://claude.ai/code/session_016832ktirXfL5q5vC5P8Fmj