Skip to content

Fix CVE-2026-29074: Update SVGO to patch Billion Laughs DoS#2319

Merged
JanPokorny merged 2 commits intomainfrom
claude/fix-svgo-dos-vulnerability-ttP4Q
Mar 6, 2026
Merged

Fix CVE-2026-29074: Update SVGO to patch Billion Laughs DoS#2319
JanPokorny merged 2 commits intomainfrom
claude/fix-svgo-dos-vulnerability-ttP4Q

Conversation

@JanPokorny
Copy link
Collaborator

Summary

Updates the SVGO dependency to version 3.3.3 to fix CVE-2026-29074 / GHSA-xpqw-6gx7-v673, a Denial of Service vulnerability through entity expansion in DOCTYPE (Billion Laughs attack). This vulnerability is transitive via @svgr/webpack → @svgr/plugin-svgo → svgo.

Linked Issues

Documentation

  • No Docs Needed: This is a security patch with no user-facing changes or API modifications.

https://claude.ai/code/session_016832ktirXfL5q5vC5P8Fmj

Add pnpm override to force svgo>=3.0.0,<3.3.3 to resolve to 3.3.3,
patching GHSA-xpqw-6gx7-v673 (Billion Laughs entity expansion DoS).

https://claude.ai/code/session_016832ktirXfL5q5vC5P8Fmj
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's security posture by patching a critical Denial of Service vulnerability. It ensures that a specific version of a key dependency is used, thereby safeguarding against potential attacks without introducing any functional changes or requiring documentation updates.

Highlights

  • Security Update: Updated the svgo dependency to version 3.3.3 to address CVE-2026-29074, which mitigates a Denial of Service vulnerability (Billion Laughs attack) caused by entity expansion in DOCTYPE.
  • Dependency Override: Implemented a pnpm override to ensure svgo is explicitly set to version 3.3.3 across the project, including its transitive dependencies, to enforce the security fix.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pnpm-lock.yaml
    • Updated the @carbon/react dependency version.
    • Added an explicit override for svgo to version 3.3.3.
    • Removed the @trysound/sax package entry and its reference within svgo's dependencies.
    • Updated the svgo package entry from 3.3.2 to 3.3.3 and adjusted its internal dependencies to use sax: 1.5.0.
  • pnpm-workspace.yaml
    • Added a new override rule for svgo to enforce version 3.3.3 project-wide, along with a descriptive comment.
Activity
  • No activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the security vulnerability GHSA-xpqw-6gx7-v673 by updating the svgo dependency to version 3.3.3 using a pnpm override. The changes in pnpm-lock.yaml are consistent with this update. I've added a comment to correct a typo in the CVE number within pnpm-workspace.yaml. Please note that the same typo (CVE-2026-29074 instead of CVE-2024-29074) is present in the pull request title and description, which you may also want to correct for clarity and accurate tracking.

# Fix CVE-2024-45296 / GHSA-9wv6-86v2-598j: path-to-regexp ReDoS vulnerability
# Transitive via mintlify -> @mintlify/previewing -> express@4.18.2
"path-to-regexp@<0.1.10": "0.1.10"
# Fix CVE-2026-29074 / GHSA-xpqw-6gx7-v673: SVGO DoS through entity expansion in DOCTYPE (Billion Laughs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There appears to be a typo in the CVE number. The correct identifier for this vulnerability is CVE-2024-29074.

  # Fix CVE-2024-29074 / GHSA-xpqw-6gx7-v673: SVGO DoS through entity expansion in DOCTYPE (Billion Laughs)

Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
@JanPokorny JanPokorny merged commit 9469517 into main Mar 6, 2026
6 of 7 checks passed
@JanPokorny JanPokorny deleted the claude/fix-svgo-dos-vulnerability-ttP4Q branch March 6, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants