Fix CVE-2025-58754: Upgrade axios to patch DoS vulnerability#2320
Fix CVE-2025-58754: Upgrade axios to patch DoS vulnerability#2320JanPokorny merged 1 commit intomainfrom
Conversation
…ility Adds a pnpm workspace override to force axios to >=1.12.0, eliminating the vulnerable axios@1.10.0 brought in transitively via mintlify -> @mintlify/scraping -> @mintlify/common -> @mintlify/models. The vulnerability (GHSA-4hjh-wcwx-xvwj) allowed an attacker to supply a large data: URI causing unbounded memory allocation and process crash (DoS), bypassing maxContentLength/maxBodyLength guards. https://claude.ai/code/session_0141PZwEdnJ66b38QFWNtgrY
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a critical security update by patching a denial-of-service vulnerability in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to upgrade the axios dependency to mitigate a Denial of Service vulnerability (GHSA-4hjh-wcwx-xvwj). While the intention to patch security vulnerabilities is commendable, my review indicates that the version of axios currently in use (1.10.0) is not affected by the cited advisory. The change therefore appears to be unnecessary for the stated purpose. Please see my specific comment for details.
| # Fix CVE-2025-58754 / GHSA-4hjh-wcwx-xvwj: axios DoS vulnerability via data: URI | ||
| # Transitive via mintlify -> @mintlify/scraping -> @mintlify/common -> @mintlify/models | ||
| "axios@<1.12.0": ">=1.12.0" |
There was a problem hiding this comment.
This override appears to be based on a misunderstanding of the vulnerability advisory GHSA-4hjh-wcwx-xvwj.
The advisory states that the affected versions of axios are < 0.28.0 and >= 1.0.0, < 1.4.0. The version currently being used via the transitive dependency chain is 1.10.0, which is not within this vulnerable range as it is greater than 1.4.0.
As a result, this change is unnecessary for fixing the specified vulnerability. If this change is intended to address a different issue, please update the description accordingly. Otherwise, this override and the related changes in pnpm-lock.yaml should be removed.
There was a problem hiding this comment.
Lies and deception!
Summary
Upgrades axios to version 1.12.0 or higher to fix CVE-2025-58754 / GHSA-4hjh-wcwx-xvwj, a denial of service vulnerability via data: URI. This dependency is pulled in transitively through the mintlify dependency chain.
Linked Issues
Documentation
https://claude.ai/code/session_0141PZwEdnJ66b38QFWNtgrY