Fix minimatch ReDoS vulnerability (CVE-2026-27903)#2321
Conversation
Add pnpm override to force minimatch@<3.1.3 to resolve to 3.1.4, which patches the combinatorial backtracking ReDoS in matchOne() (GHSA-7r86-cg39-jmmj). The vulnerable 3.1.2 version was a transitive dependency via @stoplight/spectral-core. https://claude.ai/code/session_01SsMomKnukR5m2q7cC1pjJ6
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's security posture by resolving a critical ReDoS vulnerability. It introduces a specific dependency override to ensure that a secure version of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a reported ReDoS vulnerability in the minimatch package by adding a pnpm override to enforce version 3.1.4. The changes correctly update pnpm-workspace.yaml to define the override and pnpm-lock.yaml to reflect the new dependency resolution. My review includes a comment to correct the vulnerability identifiers in the pnpm-workspace.yaml file, as the current ones appear to be incorrect. This is important for long-term maintainability and security tracking. I also recommend updating the PR title and description to reflect the correct vulnerability information.
| # Fix CVE-2024-45296 / GHSA-9wv6-86v2-598j: path-to-regexp ReDoS vulnerability | ||
| # Transitive via mintlify -> @mintlify/previewing -> express@4.18.2 | ||
| "path-to-regexp@<0.1.10": "0.1.10" | ||
| # Fix CVE-2026-27903 / GHSA-7r86-cg39-jmmj: minimatch ReDoS vulnerability |
There was a problem hiding this comment.
The vulnerability identifiers in this comment are incorrect. CVE-2026-27903 is not a valid CVE, likely due to a typo in the year. The referenced GHSA-7r86-cg39-jmmj corresponds to CVE-2022-3517 and affects minimatch versions < 3.0.5, while the lockfile indicates version 3.1.2 was in use. Incorrect identifiers hinder security auditing. The comment should be updated with the correct identifiers, or the incorrect ones should be removed.
# Fix minimatch ReDoS vulnerabilitySigned-off-by: Jan Pokorný <JenomPokorny@gmail.com>
Summary
Add pnpm override to fix CVE-2026-27903 / GHSA-7r86-cg39-jmmj, a ReDoS vulnerability in minimatch. The vulnerability is transitive via @stoplight/spectral-core and is resolved by enforcing minimatch version 3.1.4 or higher.
Linked Issues
Documentation
https://claude.ai/code/session_01SsMomKnukR5m2q7cC1pjJ6