Skip to content

Upgrade path-to-regexp to 0.1.12 to fix ReDoS vulnerabilities#2322

Merged
JanPokorny merged 2 commits intomainfrom
claude/fix-redos-vulnerability-FSzfn
Mar 9, 2026
Merged

Upgrade path-to-regexp to 0.1.12 to fix ReDoS vulnerabilities#2322
JanPokorny merged 2 commits intomainfrom
claude/fix-redos-vulnerability-FSzfn

Conversation

@JanPokorny
Copy link
Collaborator

Summary

Upgrades the path-to-regexp dependency override from version 0.1.10 to 0.1.12 to address two additional ReDoS (Regular Expression Denial of Service) vulnerabilities in addition to the previously patched CVE-2024-45296.

Changes

Linked Issues

Documentation

  • No Docs Needed: This is a security patch for a transitive dependency with no user-facing changes.

https://claude.ai/code/session_01UdfkMMGcQDbePZ6F22TDGe

The previous override pinned path-to-regexp@<0.1.10 to 0.1.10, which
fixed CVE-2024-45296 but left the codebase vulnerable to the subsequent
ReDoS vulnerability CVE-2024-52798 / GHSA-rhx6-c78j-4q9w, which requires
>= 0.1.12.

Updates the pnpm workspace override to require 0.1.12 for all
path-to-regexp versions below it (transitive via mintlify -> express).

https://claude.ai/code/session_01UdfkMMGcQDbePZ6F22TDGe
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's security posture by updating a critical transitive dependency, path-to-regexp, to a version that mitigates recently discovered ReDoS vulnerabilities. The changes are purely for security patching and do not introduce any new features or user-facing modifications, ensuring a stable and more secure application environment.

Highlights

  • Dependency Upgrade: Upgraded the path-to-regexp dependency override from version 0.1.10 to 0.1.12.
  • Security Fixes: Addressed two additional Regular Expression Denial of Service (ReDoS) vulnerabilities (CVE-2024-52798 / GHSA-rhx6-c78j-4q9w) in path-to-regexp, building upon the previously patched CVE-2024-45296.
  • Configuration Updates: Updated the pnpm-workspace.yaml override constraint for path-to-regexp to reflect the new version and included the new CVE in the associated comment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pnpm-lock.yaml
    • Updated the path-to-regexp dependency to version 0.1.12, including its integrity hash and references within snapshots.
    • Updated the @carbon/react dependency to version 1.102.0.
    • Modified the path-to-regexp override constraint from <0.1.10 to <0.1.12.
  • pnpm-workspace.yaml
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly upgrades path-to-regexp to version 0.1.12 to mitigate several ReDoS vulnerabilities. The changes in pnpm-workspace.yaml and the corresponding lock file update are appropriate. I've added one suggestion to improve the clarity of the comment in pnpm-workspace.yaml for future maintenance.

@@ -1,7 +1,7 @@
overrides:
# Fix CVE-2024-45296 / GHSA-9wv6-86v2-598j: path-to-regexp ReDoS vulnerability
# Fix CVE-2024-45296 / GHSA-9wv6-86v2-598j and CVE-2024-52798 / GHSA-rhx6-c78j-4q9w: path-to-regexp ReDoS vulnerability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better clarity and to be more comprehensive, consider updating the comment to reflect that this override fixes multiple ReDoS vulnerabilities. Mentioning the latest CVE or a more general statement can be more maintainable, as this upgrade to 0.1.12 resolves more than just the two CVEs listed.

  # Fix path-to-regexp ReDoS vulnerabilities (up to CVE-2024-52798 / GHSA-rhx6-c78j-4q9w)

Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
@JanPokorny JanPokorny merged commit 40ebf34 into main Mar 9, 2026
5 of 6 checks passed
@JanPokorny JanPokorny deleted the claude/fix-redos-vulnerability-FSzfn branch March 9, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants