Upgrade path-to-regexp to 0.1.12 to fix ReDoS vulnerabilities#2322
Upgrade path-to-regexp to 0.1.12 to fix ReDoS vulnerabilities#2322JanPokorny merged 2 commits intomainfrom
Conversation
The previous override pinned path-to-regexp@<0.1.10 to 0.1.10, which fixed CVE-2024-45296 but left the codebase vulnerable to the subsequent ReDoS vulnerability CVE-2024-52798 / GHSA-rhx6-c78j-4q9w, which requires >= 0.1.12. Updates the pnpm workspace override to require 0.1.12 for all path-to-regexp versions below it (transitive via mintlify -> express). https://claude.ai/code/session_01UdfkMMGcQDbePZ6F22TDGe
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's security posture by updating a critical transitive dependency, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly upgrades path-to-regexp to version 0.1.12 to mitigate several ReDoS vulnerabilities. The changes in pnpm-workspace.yaml and the corresponding lock file update are appropriate. I've added one suggestion to improve the clarity of the comment in pnpm-workspace.yaml for future maintenance.
| @@ -1,7 +1,7 @@ | |||
| overrides: | |||
| # Fix CVE-2024-45296 / GHSA-9wv6-86v2-598j: path-to-regexp ReDoS vulnerability | |||
| # Fix CVE-2024-45296 / GHSA-9wv6-86v2-598j and CVE-2024-52798 / GHSA-rhx6-c78j-4q9w: path-to-regexp ReDoS vulnerability | |||
There was a problem hiding this comment.
For better clarity and to be more comprehensive, consider updating the comment to reflect that this override fixes multiple ReDoS vulnerabilities. Mentioning the latest CVE or a more general statement can be more maintainable, as this upgrade to 0.1.12 resolves more than just the two CVEs listed.
# Fix path-to-regexp ReDoS vulnerabilities (up to CVE-2024-52798 / GHSA-rhx6-c78j-4q9w)Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
Summary
Upgrades the
path-to-regexpdependency override from version 0.1.10 to 0.1.12 to address two additional ReDoS (Regular Expression Denial of Service) vulnerabilities in addition to the previously patched CVE-2024-45296.Changes
path-to-regexpversion constraint from<0.1.10to<0.1.120.1.10to0.1.12Linked Issues
Documentation
https://claude.ai/code/session_01UdfkMMGcQDbePZ6F22TDGe