fix(skill): set suggested model from original agent#2371
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where agents relying on tool-calling functionality can fail at runtime if the platform falls back to an LLM that does not support function calling. The changes introduce comprehensive documentation and updated skill guides to ensure developers explicitly specify and verify that suggested models possess the necessary tool-calling capabilities, thereby preventing runtime failures caused by incompatible fallback models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
43b8d36 to
39c005b
Compare
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the critical issue of agents failing at runtime when a fallback LLM does not support tool calling. The updates to SKILL.md introduce clear checklist items for developers to verify model capabilities, while references/llm-services.md provides detailed explanations, concrete rules, and helpful BAD/GOOD code examples. These changes significantly improve the clarity and robustness of the skill development process by guiding users to explicitly consider and configure model capabilities, thereby preventing common runtime failures.
Note: Security Review has been skipped due to the limited scope of the PR.
39c005b to
cf1f02a
Compare
cf1f02a to
200eccc
Compare
- Add Anti-Pattern bullet to llm-services.md: use the same model identifier as the original agent, not a generic one - Add Step 5a checklist item to SKILL.md: set suggested model to match the model used in the original agent Signed-off-by: penge <ppenge@gmail.com>
200eccc to
26d4b1c
Compare
Problem
When wrapping an agent, the skill used a generic model as the
suggestedhint inLLMServiceExtensionSpec.single_demand(). The platform may allocate a different model if the suggested one is unavailable, which can cause runtime failures.Changes
references/llm-services.md: Add Anti-Pattern bullet — do not use a generic model assuggested; use the same model identifier as the original agent.SKILL.md: Add Step 5a checklist item — setsuggestedmodel to match the model used in the original agent.