Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default date fields #45

Merged
merged 4 commits into from
Jan 31, 2024
Merged

change default date fields #45

merged 4 commits into from
Jan 31, 2024

Conversation

jbennettufl
Copy link
Contributor

This modification would remove the datecollected field formatted as a date and replace it with the DarwinCore text fields for eventDate, year, month, and day instead.

@jbennettufl
Copy link
Contributor Author

This should not be merged quite yet as it will cause a breaking change for another package as pointed out here: https://github.com/ropensci/spocc/blob/59f6b3b192cd8a7bb990aab94748f3bc7b044dac/R/plugins.r#L266 from the original issue which is located here: #44. This code uses the date to order the specimens in a list using a field formatted as a date.

@mgaynor1
Copy link
Collaborator

This should not be merged quite yet as it will cause a breaking change for another package as pointed out here: https://github.com/ropensci/spocc/blob/59f6b3b192cd8a7bb990aab94748f3bc7b044dac/R/plugins.r#L266 from the original issue which is located here: #44. This code uses the date to order the specimens in a list using a field formatted as a date.

Contact spocc?

@jbennettufl
Copy link
Contributor Author

Ok, what should I say to them?

@mgaynor1
Copy link
Collaborator

Here you go: ropensci/spocc#263

@jbennettufl
Copy link
Contributor Author

@mgaynor1 I've added some documentation about the fields and have added your contact info into the contributors list. If there is anything in there you would like to update or finalize feel free to let me know.

@mgaynor1
Copy link
Collaborator

Jessie - I updated the documentation to reflect that we are only updating the R function, the API has not been modified and the field is still available via the API (and the function, if it is indicated in the fields argument). I also added proper documentation for the return. I am unsure what the Darwin Core equivalent for collector and geopoint is, so these links are missing.

I think it is ready to go.

@jbennettufl jbennettufl merged commit 73bd493 into master Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants