Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ethers v6 #225

Merged
merged 25 commits into from
Oct 30, 2023
Merged

Feature/ethers v6 #225

merged 25 commits into from
Oct 30, 2023

Conversation

PierreJeanjacquot
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot commented Oct 17, 2023

ethers v5 -> v6 migration:

Ethers have been upgraded to v6 without changing the iexec SDK API
Under the hood we have the following changes

  • extraction of plain objects from ethers proxies (formatEthersResult)
  • wrapping of bigint used by ethers v6 into BN exposed by iexec
  • adaptation of ethers error messages extraction
  • adaptation of events extraction from transaction receipts

Misc:

  • due to a bug in ganache affecting ethers v6 and the project being sunsetting, ganache is temporarily replaced by openethereum client in tests, this also reduces the number of services running for the tests
    • ⚠️ because "instamine" does not exist in the openethereum client, test execution time increased by 50%
    • openethereum is also sunsetting and is planned to be replaced by neithermind (current client used by iExec)
  • EIP1559 support for wallet sweep
  • typos fix

TODO:

  • find a suitable "instamine" replacer for ganache (asap)
  • replace openethereum by neithermind in tests (asap)
  • use native bigint instead of BN (next major release)

Copy link

@SeddikBellamine SeddikBellamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording changes

docs/interfaces/internal_.Eip1193Provider.md Show resolved Hide resolved
src/common/execution/deal.js Outdated Show resolved Hide resolved
@PierreJeanjacquot PierreJeanjacquot marked this pull request as ready for review October 25, 2023 08:31
@PierreJeanjacquot PierreJeanjacquot merged commit 16ee1da into next Oct 30, 2023
4 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the feature/ethers-v6 branch October 30, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants