-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ethers v6 #225
Merged
Merged
Feature/ethers v6 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeddikBellamine
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor wording changes
PierreJeanjacquot
force-pushed
the
feature/ethers-v6
branch
from
October 25, 2023 08:02
9f5b654
to
ba0eb95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethers v5 -> v6 migration:
Ethers have been upgraded to v6 without changing the iexec SDK API
Under the hood we have the following changes
formatEthersResult
)bigint
used by ethers v6 intoBN
exposed by iexecMisc:
ganache
affecting ethers v6 and the project being sunsetting, ganache is temporarily replaced byopenethereum
client in tests, this also reduces the number of services running for the testsopenethereum
client, test execution time increased by 50%openethereum
is also sunsetting and is planned to be replaced byneithermind
(current client used by iExec)TODO:
ganache
(asap)openethereum
byneithermind
in tests (asap)bigint
instead ofBN
(next major release)