Skip to content

Conversation

konstkarapan
Copy link

@konstkarapan konstkarapan commented Oct 6, 2023

Greek🇬🇷 language for the inav configurator

added el/messages.json
@mmosca
Copy link
Collaborator

mmosca commented Oct 6, 2023

I will try to review it and see if some other users can give feedback as well.

Thank you for you effort!

@konstkarapan konstkarapan reopened this Feb 21, 2024
@konstkarapan
Copy link
Author

konstkarapan commented Feb 21, 2024

The original translation effort was a bit of a mess. Now every line matches it's English counterpart making it easier to review and make future additions

@mmosca
Copy link
Collaborator

mmosca commented Jun 24, 2024

@konstkarapan can you test this with the latest configurator, since we now changed to Electron?

@konstkarapan
Copy link
Author

I'll test it asap

@sensei-hacker
Copy link
Collaborator

You may find that el needs to be added on about line 13 of js/localization.js

const store = new Store();

const availableLanguages = ['en'];
const availableLanguages = ['en' , 'el'];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably auto populate this list.

Not a change you need to make, but an acknowledgement that this is not ideal.

@konstkarapan
Copy link
Author

@mmosca What is the expected behaviour of the language selector at the application settings? Changing languages on it seems to do nothing

revert some terms back to English and correct some typos
@sensei-hacker
Copy link
Collaborator

I'm sorry, this was left hanging. Is there anyone else who is able to read Greek and can look these over?

In the United States, we have a saying for when we don't understand something, not even a little bit. When there is something that we can't comprehend at all, we say "it's all Greek to me". That applies here - I have no idea if these are perfect, or if it's a bunch of obscene words in Greek. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants