Skip to content

Conversation

@kedeng
Copy link
Contributor

@kedeng kedeng commented May 14, 2025

If we choose "Keep current settings (Not recommended)", then periodicStatusUpdater.stop(). This will cause the sensor status icons not to update, replugging the USB did not solve the problem. The only way is closing and reopening the INAV Configurator. So if we choose a non-rebooted option, we should not let the periodicStatusUpdater stop.

@sensei-hacker sensei-hacker merged commit 3e466a8 into iNavFlight:master Oct 31, 2025
6 checks passed
@qodo-merge-pro
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
Missing audit logs: The change alters reboot/stop behavior for periodicStatusUpdater without adding any
logging to record the action taken or the selected preset, making it unclear who triggered
it and what outcome occurred.

Referred Code
if(selectedDefaultPreset.reboot) {
    periodicStatusUpdater.stop();
}
Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No null checks: The new conditional relies on selectedDefaultPreset.reboot but adds no guards if
selectedDefaultPreset is null/undefined or if periodicStatusUpdater.stop is unavailable,
leaving potential edge cases unhandled.

Referred Code
if(selectedDefaultPreset.reboot) {
    periodicStatusUpdater.stop();
}
Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Input not validated: The code consumes selectedDefaultPreset.reboot without visible validation or sanitization
of the external input object, which could be undefined or malformed in some flows.

Referred Code
if(selectedDefaultPreset.reboot) {
    periodicStatusUpdater.stop();
}
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants