Skip to content

Conversation

smsnvc
Copy link
Contributor

@smsnvc smsnvc commented May 30, 2025

Adding Ukrainian translations to keep Ukrainian version 100% translated

@smsnvc
Copy link
Contributor Author

smsnvc commented May 31, 2025

Hi @bfmvsa ,

Here are recent changes to keep Ukrainian at 100% translated. Please have a look as a native speaker.

Hi @MrD-RC , @sensei-hacker ,

If you don't mind, I'd like this merged so that it does not lay in my infinite backlogs.

@sensei-hacker
Copy link
Collaborator

Is there anyone who can independently take a look at this, double-check it?

@bfmvsa
Copy link
Contributor

bfmvsa commented May 31, 2025

Looks good for me. But I am not sure we need to translate
"currentLanguage": {
"message": "укр"
},
In other files we do not translate this. Probably we should add a comment there "Don't translate!"

@sensei-hacker
Copy link
Collaborator

sensei-hacker commented May 31, 2025

Yeah currentLanguage should be "uk".
Maybe I should have called that currentLanguageCode or similar.

It's used to tell the browser which language it should be using - that is should be using the uk strings, not the en strings, etc.

@smsnvc can you please put that back to "uk"?

@smsnvc
Copy link
Contributor Author

smsnvc commented May 31, 2025

@bfmvsa , thanks a lot!

@sensei-hacker , I've changed currentLanguage to uk.

@sensei-hacker sensei-hacker merged commit 644cee2 into iNavFlight:master May 31, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants