Skip to content

Configurator as Web APP (PWA) #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Scavanger wants to merge 58 commits into
base: maintenance-10.x
Choose a base branch
from

Add warning message, temp clodflare

c0f4f63
Select commit
Loading
Failed to load commit list.
Draft

Configurator as Web APP (PWA) #2448

Add warning message, temp clodflare
c0f4f63
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 5, 2026 in 1m 58s

Quality Gate failed

Failed conditions
2 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 72 in js/web/browser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this character class by the character itself. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmEHaWZjjPp20blh&open=AZy-bmEHaWZjjPp20blh&pullRequest=2448

Check failure on line 187 in js/serial_backend.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 45 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmKdaWZjjPp20bmN&open=AZy-bmKdaWZjjPp20bmN&pullRequest=2448

Check warning on line 3678 in tabs/mission_control.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected non-Promise value in a boolean conditional. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmV3aWZjjPp20bnM&open=AZy-bmV3aWZjjPp20bnM&pullRequest=2448

Check failure on line 3041 in tabs/mission_control.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmV3aWZjjPp20bnJ&open=AZy-bmV3aWZjjPp20bnJ&pullRequest=2448

Check warning on line 133 in js/connection/connection.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmJZaWZjjPp20bmK&open=AZy-bmJZaWZjjPp20bmK&pullRequest=2448

Check warning on line 22 in tabs/firmware_flasher.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Platform'. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmbMaWZjjPp20bnh&open=AZy-bmbMaWZjjPp20bnh&pullRequest=2448

Check failure on line 309 in tabs/led_strip.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmO3aWZjjPp20bmu&open=AZy-bmO3aWZjjPp20bmu&pullRequest=2448

Check warning on line 7 in js/globalUpdates.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Platform'. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmBYaWZjjPp20blG&open=AZy-bmBYaWZjjPp20blG&pullRequest=2448

Check warning on line 37 in js/bridge.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmMXaWZjjPp20bmV&open=AZy-bmMXaWZjjPp20bmV&pullRequest=2448

Check warning on line 222 in tabs/sitl.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmW9aWZjjPp20bnV&open=AZy-bmW9aWZjjPp20bnV&pullRequest=2448

Check warning on line 336 in js/web/SITL-Webassembly.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmESaWZjjPp20bl0&open=AZy-bmESaWZjjPp20bl0&pullRequest=2448

Check warning on line 95 in js/bridge.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmMXaWZjjPp20bma&open=AZy-bmMXaWZjjPp20bma&pullRequest=2448

Check failure on line 170 in tabs/firmware_flasher.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmbMaWZjjPp20bnj&open=AZy-bmbMaWZjjPp20bnj&pullRequest=2448

Check warning on line 272 in js/web/SITL-Webassembly.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant jump. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmESaWZjjPp20blz&open=AZy-bmESaWZjjPp20blz&pullRequest=2448

Check failure on line 642 in tabs/sitl.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmW9aWZjjPp20bnd&open=AZy-bmW9aWZjjPp20bnd&pullRequest=2448

Check warning on line 140 in js/web/SITL-Webassembly.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Default parameters should be last. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmESaWZjjPp20blw&open=AZy-bmESaWZjjPp20blw&pullRequest=2448

Check warning on line 6 in js/connection/connectionExt.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'bridge'. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmIkaWZjjPp20bmC&open=AZy-bmIkaWZjjPp20bmC&pullRequest=2448

Check failure on line 37 in tabs/search.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmU4aWZjjPp20bnD&open=AZy-bmU4aWZjjPp20bnD&pullRequest=2448

Check warning on line 202 in js/web/SITL-Webassembly.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use an object spread instead of `Object.assign` eg: `{ ...foo }`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmESaWZjjPp20blx&open=AZy-bmESaWZjjPp20blx&pullRequest=2448

Check warning on line 69 in js/web/browser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unnecessary escape character: \.. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmEHaWZjjPp20bld&open=AZy-bmEHaWZjjPp20bld&pullRequest=2448

Check warning on line 3496 in tabs/mission_control.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected non-Promise value in a boolean conditional. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmV3aWZjjPp20bnL&open=AZy-bmV3aWZjjPp20bnL&pullRequest=2448

Check warning on line 14 in js/web/browser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "self". 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmEHaWZjjPp20blR&open=AZy-bmEHaWZjjPp20blR&pullRequest=2448

Check warning on line 74 in js/web/browser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmEHaWZjjPp20blj&open=AZy-bmEHaWZjjPp20blj&pullRequest=2448

Check warning on line 71 in js/web/browser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmEHaWZjjPp20ble&open=AZy-bmEHaWZjjPp20ble&pullRequest=2448

Check warning on line 58 in js/web/browser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZy-bmEHaWZjjPp20blV&open=AZy-bmEHaWZjjPp20blV&pullRequest=2448
View more details on SonarQubeCloud