Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider query string field for internal redirects #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DeathAngelDaemon
Copy link

Please have a look, if this fits your code structure.
In my local Sitecore instance it works as expected.

See issue #27 for more information.

@iamandycohen
Copy link
Owner

Hello Anna. I am totally open to merging / accepting this pull request. Can you please provide a reason why this is necessary? I am totally open to this, just curious.

Thank you,

Andy

@DeathAngelDaemon
Copy link
Author

Hello Andy,
we have the case that we want to redirect a shortlink like www.domain.com/shortlink to an internal Sitecore page with a query string (which will be handled by a controller action) like www.domain.com/path/to/sitecore/page?query=string.
I use a Simple Redirect for this case. At the "Target" field I insert an internal link and there is a field "Query string" which will be appended to the internal link. Normally. But this field was not considered by your plugin so far. That's why I added it.
I hope this makes it clear. :)
Anna

@apoetzsch apoetzsch deleted the 20171027_issue27_consider-query-string-internal-redirect branch March 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants