feature/fix: add support onBlur and onFocus#489
Open
georg-pandekhfumani-redshelf wants to merge 1 commit intoiamhosseindhv:masterfrom
Open
feature/fix: add support onBlur and onFocus#489georg-pandekhfumani-redshelf wants to merge 1 commit intoiamhosseindhv:masterfrom
georg-pandekhfumani-redshelf wants to merge 1 commit intoiamhosseindhv:masterfrom
Conversation
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
Author
|
Hey @iamhosseindhv, did you get an ability to look at this PR? If you need from me to clarify something feel free to ask. |
|
Hey, thanks for doing this! Hopefully someone will review it soon? |
|
With a forwarded ref's help someone can do this in a custom notification component without the need for adding the handlers as you did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

issue: #490
Problem: So, basically if we talking about accessibility - when user have focus on the snackbar we shouldn't hide snackbar after some autoHideDuration time. Notistack doesn't supports onFocus and onBlur events.
Steps to reproduce problem:
autoHideDurationtime passes.How to test:
autoHideDurationprovided time.