Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit:offset tests. #5269

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

boweiliu
Copy link
Contributor

@boweiliu boweiliu commented Jan 23, 2023

Description
Adds some unit tests for the unit: offset behavior.

Issue
Fixes: (link to issue)

Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)

Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

⚠️ No Changeset found

Latest commit: 742d3bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@boweiliu
Copy link
Contributor Author

@dylans could i get some help running the workflows?

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boweiliu Thanks, always appreciate good quality tests getting added! It looks like you just need to run Prettier on your PR and then we should be ready to land it.

@dylans
Copy link
Collaborator

dylans commented Feb 22, 2023

@boweiliu A reminder of my previous note:

Thanks, always appreciate good quality tests getting added! It looks like you just need to run Prettier on your PR and then we should be ready to land it.

@dylans
Copy link
Collaborator

dylans commented Dec 16, 2023

@boweiliu quick reminder, run prettier on this and then we can land it.

@dylans dylans closed this Aug 20, 2024
@dylans dylans reopened this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants