-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disabling Auth0 #967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! Much better approach than mine. I've tested thoroughly and everything works fantastic! Excited for what this will allow for the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool fix! Works great for me locally. Just a couple questions.
'user' | ||
] | ||
}, | ||
// FIXME: pick a better email address for both backend and frontend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you looking for a real email address here or just a different fake/placeholder one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a different one. This email address appears in the Notes section of each feed.
lib/public/components/UserAccount.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth it to add a status message in this pane if AUTH0_DISABLED
is true, that says something along the lines of "You're running datatools without user authentication enabled. Features such as user management, account management and feed activity watching are unavailable"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts @miles-grant-ibigroup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The homepage might be a better place? Could add a warning above the recent activity section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the message to the home page, above Recent Activity (969af57)
Checklist
dev
before they can be merged tomaster
)Description
This PR allows running the datatools UI without having to log in using Auth0.
When Auth0 is disabled:
The PR is based on https://github.com/ibi-group/datatools-ui/tree/auth-disable but simplifies the permission checks by creating an admin user on loading.
Rough edges caused by not knowing what panes will be available until after a few render passes - I think that can be addressed in a subsequent PR:
To disable Auth0, insert a line with
DISABLE_AUTH: true
inenv.yml
for both frontend and backend configurations.No other changes are needed on the backend.
This PR might address #962.