feat: add metrics module with classification metrics #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to start making some progress on supporting a new
ibis_ml.metrics
module might look like with the first pass to support classification metrics.
In this initial pass, the functions accept the
y_pred
andy_true
as Ibis tableexpression columns.
A few thoughts
to start with classification only as an "experimental" type of op.
What could go wrong?
I anticipate the inputs are coming from the same table expression, although testing
this behavior (or at least documenting) with what happens with input from two different
table expressions would be necessary.
Resolves (partially) #174
Edit: As far as testing goes, I wonder if more precision might be necessary.