Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics module with classification metrics #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IndexSeek
Copy link
Member

@IndexSeek IndexSeek commented Dec 8, 2024

I wanted to start making some progress on supporting a new ibis_ml.metrics
module might look like with the first pass to support classification metrics.

In this initial pass, the functions accept the y_pred and y_true as Ibis table
expression columns.

A few thoughts

  • Should we go ahead and try this with regression metrics? Or would it be okay
    to start with classification only as an "experimental" type of op.
  • Do we need a "metrics" folder that contains "regression" and "classification" files?
  • Is there a more effective way to test this than to compare it to scikit-learns metrics?

What could go wrong?

I anticipate the inputs are coming from the same table expression, although testing
this behavior (or at least documenting) with what happens with input from two different
table expressions would be necessary.

Resolves (partially) #174

Edit: As far as testing goes, I wonder if more precision might be necessary.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (7d2d021) to head (a236949).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   90.35%   90.57%   +0.22%     
==========================================
  Files          29       31       +2     
  Lines        2083     2132      +49     
==========================================
+ Hits         1882     1931      +49     
  Misses        201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepyaman
Copy link
Collaborator

Sorry, I didn't see this earlier; will try to take a look soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants