chore: remove remove_aliases kwarg from duckdb compiler

ibis-project · Sep 19, 2023 · d97ad13 · d97ad13
1 parent 2422352
commit d97ad13
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/ibis/backends/duckdb/compiler/relations.py b/ibis/backends/duckdb/compiler/relations.py
@@ -65,7 +65,7 @@ def _selection(op: ops.Selection, *, table, needs_alias=False, aliases, **kw):
 @translate_rel.register(ops.Aggregation)
 def _aggregation(op: ops.Aggregation, *, table, **kw):
     tr_val = partial(translate_val, **kw)
-    tr_val_no_alias = partial(translate_val, render_aliases=False, **kw)
+    tr_val_no_alias = partial(translate_val, **kw)
 
     by = tuple(map(tr_val, op.by))
     metrics = tuple(map(tr_val, op.metrics))

diff --git a/ibis/backends/duckdb/compiler/values.py b/ibis/backends/duckdb/compiler/values.py
@@ -52,11 +52,9 @@ def _column(op, *, aliases, **_):
 
 
 @translate_val.register(ops.Alias)
-def _alias(op, render_aliases: bool = True, **kw):
-    val = translate_val(op.arg, render_aliases=render_aliases, **kw)
-    if render_aliases:
-        return sg.alias(val, op.name)
-    return val
+def _alias(op, **kw):
+    val = translate_val(op.arg, **kw)
+    return sg.alias(val, op.name)
 
 
 ### Literals